You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Mehant Baid <ba...@gmail.com> on 2014/05/09 10:00:18 UTC

Review Request 21258: Support for SHOW FILES command

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21258/
-----------------------------------------------------------

Review request for drill and Jacques Nadeau.


Repository: drill-git


Description
-------

Added support for SHOW FILES command. Currently we only support simple show files command and don't support 'like' or 'where' clause. 


Diffs
-----

  exec/java-exec/src/main/codegen/data/Parser.tdd 176ee79 
  exec/java-exec/src/main/codegen/includes/parserImpls.ftl 5b6e2b5 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFilesCommandResult.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowFiles.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java 92a1efc 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/HasFileSystemSchema.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java cbaf651 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java ded0848 

Diff: https://reviews.apache.org/r/21258/diff/


Testing
-------

Added unit tests


Thanks,

Mehant Baid


Re: Review Request 21258: Support for SHOW FILES command

Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21258/
-----------------------------------------------------------

(Updated May 9, 2014, 9:32 p.m.)


Review request for drill and Jacques Nadeau.


Changes
-------

Updated patch to use TimeStamp vector for modificationTime and accessTime fields.


Repository: drill-git


Description
-------

Added support for SHOW FILES command. Currently we only support simple show files command and don't support 'like' or 'where' clause. 


Diffs (updated)
-----

  exec/java-exec/src/main/codegen/data/Parser.tdd 176ee79 
  exec/java-exec/src/main/codegen/includes/parserImpls.ftl 5b6e2b5 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFilesCommandResult.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowFiles.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java 92a1efc 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/HasFileSystemSchema.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java cbaf651 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoDataType.java 8ecb29f 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoRecordReader.java 4203abc 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/Writers.java b986be8 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java ded0848 

Diff: https://reviews.apache.org/r/21258/diff/


Testing
-------

Added unit tests


Thanks,

Mehant Baid