You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/12/01 19:16:45 UTC
[GitHub] [solr] HoustonPutman opened a new pull request, #1204: SOLR-15955: Fix dependency in hadoop-auth
HoustonPutman opened a new pull request, #1204:
URL: https://github.com/apache/solr/pull/1204
This dependency is not compileTimeOnly. I think this was only done because of the weird old way of handling jetty dependencies.
After https://issues.apache.org/jira/browse/SOLR-16158 this should no longer be an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1204: SOLR-15955: Fix dependency in hadoop-auth
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1204:
URL: https://github.com/apache/solr/pull/1204#discussion_r1037566297
##########
solr/modules/hadoop-auth/build.gradle:
##########
@@ -103,7 +103,7 @@ dependencies {
exclude group: "org.apache.yetus", module: "audience-annotations"
})
// required for instantiating a Zookeeper server in tests or embedded
- runtimeOnly ('org.xerial.snappy:snappy-java')
+ testRuntimeOnly ('org.xerial.snappy:snappy-java')
Review Comment:
I'd be surprised if the `runtimeOnly` version is needed?
at least in the `hdfs` module - there is only the `testRuntimeOnly`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a diff in pull request #1204: SOLR-15955: Fix dependency in hadoop-auth
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on code in PR #1204:
URL: https://github.com/apache/solr/pull/1204#discussion_r1037479484
##########
solr/modules/hadoop-auth/build.gradle:
##########
@@ -103,7 +103,7 @@ dependencies {
exclude group: "org.apache.yetus", module: "audience-annotations"
})
// required for instantiating a Zookeeper server in tests or embedded
- runtimeOnly ('org.xerial.snappy:snappy-java')
+ testRuntimeOnly ('org.xerial.snappy:snappy-java')
Review Comment:
this already exists above as `runtimeOnly`, but maybe we need it for tests as well? I don't know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1204: SOLR-15955: Fix dependency in hadoop-auth
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1204:
URL: https://github.com/apache/solr/pull/1204#discussion_r1037567043
##########
solr/modules/hadoop-auth/build.gradle:
##########
@@ -103,7 +103,7 @@ dependencies {
exclude group: "org.apache.yetus", module: "audience-annotations"
})
// required for instantiating a Zookeeper server in tests or embedded
- runtimeOnly ('org.xerial.snappy:snappy-java')
+ testRuntimeOnly ('org.xerial.snappy:snappy-java')
Review Comment:
However in solr/core/build.gradle - `runtimeOnly ('org.xerial.snappy:snappy-java')` exists... so I'm conflicted.
Requires more digging but not going to stop this from getting merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman merged pull request #1204: SOLR-15955: Fix dependency in hadoop-auth
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged PR #1204:
URL: https://github.com/apache/solr/pull/1204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org