You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2025/05/03 21:13:57 UTC
Re: [PR] Fix loopback [beam]
liferoad commented on code in PR #34678:
URL: https://github.com/apache/beam/pull/34678#discussion_r2072467368
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/Environments.java:
##########
@@ -219,20 +219,16 @@ public static Environment createDockerEnvironment(String dockerImageUrl) {
}
private static Environment createExternalEnvironment(String externalServiceAddress) {
- if (externalServiceAddress.isEmpty()) {
- throw new IllegalArgumentException(
- String.format(
- "External service address must not be empty (set it using '--environmentOptions=%s=...'?).",
- externalServiceAddressOption));
+ // Create the payload builder. If the address is empty, the payload will be empty,
+ // acting as a placeholder for late binding (e.g., for LOOPBACK environment).
Review Comment:
Updated the comments to mention LOOPBACK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org