[GitHub] [madlib] kaknikhil commented on a change in pull request #576: Release v1.19.0 rc2

[GitBox <gi...@apache.org>]

kaknikhil commented on a change in pull request #576:
URL: https://github.com/apache/madlib/pull/576#discussion_r779114508



##########
File path: deploy/Readme_OSX
##########
@@ -0,0 +1,22 @@
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+
+MADlib Tarball Usage for OSX
+
+This tarball is generated for using MADlib on OSX devices.

Review comment:
       I would suggest that we reword this a bit
   
   1. We don't need to mention `After unpacking` since this README is only accessible after the user would have unpacked already.
   1. Mention that link_madlib_folders.sh needs to be run from the directory that it's located in. Also add a warning that if it's run from somewhere else, it will not work and that it might have unintended side effects like a random bin file getting deleted




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org