[GitHub] [airflow] potiuk commented on a diff in pull request #27145: Add support for DAG display name different than dag_id

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #27145:
URL: https://github.com/apache/airflow/pull/27145#discussion_r1009013748


##########
airflow/models/dag.py:
##########
@@ -451,6 +453,7 @@ def __init__(
             max_active_tasks = concurrency
         self._max_active_tasks = max_active_tasks
         self._pickle_id: int | None = None
+        self._display_name = dag_id if display_name is None else display_name

Review Comment:
   Yep. We discussed slugifying the name - that can also be an option, however I think adding optional name to be displayed next to id is a better approach - because having a unique id tha tis "known" and does not require to follow the very same slugifying algorithm is better (for any case where Human seeing a good name has to now what unique id is used)
   
   But seems I am in a minority, and it's not something I feel strongly about, so I am ok with any solutiom - somebody hopefully finally will implement it rather than just talking about it (I think this is about 4th discussion about it I recall). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org