You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by sf...@apache.org on 2013/03/31 22:13:48 UTC
svn commit: r1463045 - /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
Author: sf
Date: Sun Mar 31 20:13:48 2013
New Revision: 1463045
URL: http://svn.apache.org/r1463045
Log:
ap_log_error already logs the error string, no need to log it twice
Modified:
httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
Modified: httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_auth_digest.c?rev=1463045&r1=1463044&r2=1463045&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/aaa/mod_auth_digest.c (original)
+++ httpd/httpd/trunk/modules/aaa/mod_auth_digest.c Sun Mar 31 20:13:48 2013
@@ -240,10 +240,8 @@ static apr_status_t initialize_secret(se
#endif
if (status != APR_SUCCESS) {
- char buf[120];
ap_log_error(APLOG_MARK, APLOG_CRIT, status, s, APLOGNO(01758)
- "error generating secret: %s",
- apr_strerror(status, buf, sizeof(buf)));
+ "error generating secret");
return status;
}
Re: svn commit: r1463045 - /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Sunday 31 March 2013, Marion & Christophe JAILLET wrote:
> they are 3 similar constructions in server/log.c
Thanks. Fixed
> Le 31/03/2013 22:13, sf@apache.org a écrit :
> > Author: sf
> > Date: Sun Mar 31 20:13:48 2013
> > New Revision: 1463045
> >
> > URL: http://svn.apache.org/r1463045
> > Log:
> > ap_log_error already logs the error string, no need to log it
> > twice
Re: svn commit: r1463045 - /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
Posted by Marion & Christophe JAILLET <ch...@wanadoo.fr>.
Hi,
they are 3 similar constructions in server/log.c
CJ
Le 31/03/2013 22:13, sf@apache.org a écrit :
> Author: sf
> Date: Sun Mar 31 20:13:48 2013
> New Revision: 1463045
>
> URL: http://svn.apache.org/r1463045
> Log:
> ap_log_error already logs the error string, no need to log it twice
>
> Modified:
> httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
>
> Modified: httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_auth_digest.c?rev=1463045&r1=1463044&r2=1463045&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/aaa/mod_auth_digest.c (original)
> +++ httpd/httpd/trunk/modules/aaa/mod_auth_digest.c Sun Mar 31 20:13:48 2013
> @@ -240,10 +240,8 @@ static apr_status_t initialize_secret(se
> #endif
>
> if (status != APR_SUCCESS) {
> - char buf[120];
> ap_log_error(APLOG_MARK, APLOG_CRIT, status, s, APLOGNO(01758)
> - "error generating secret: %s",
> - apr_strerror(status, buf, sizeof(buf)));
> + "error generating secret");
> return status;
> }
>
>
>
>