You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2012/07/11 09:45:16 UTC

git commit: Minor improvements.

Updated Branches:
  refs/heads/master 8b46b50f8 -> b36939b32


Minor improvements.

Do not print the page markup in a test (debugging).
Add generics.
Remove the leading 'on' for the events (it is cut anyway)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/b36939b3
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/b36939b3
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/b36939b3

Branch: refs/heads/master
Commit: b36939b32d5de37098d1554d0612357ba7bbc774
Parents: 8b46b50
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Wed Jul 11 10:38:11 2012 +0300
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Wed Jul 11 10:38:11 2012 +0300

----------------------------------------------------------------------
 .../java/org/apache/wicket/BehaviorUrlTest.java    |    2 +-
 .../devutils/diskstore/browser/BrowserPanel.java   |    2 +-
 .../wicket/examples/ajax/builtin/ChoicePage.java   |    2 +-
 .../examples/ajax/builtin/tree/EditablePanel.java  |    6 +++---
 4 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/b36939b3/wicket-core/src/test/java/org/apache/wicket/BehaviorUrlTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/BehaviorUrlTest.java b/wicket-core/src/test/java/org/apache/wicket/BehaviorUrlTest.java
index 0ace3d3..e89dfcb 100644
--- a/wicket-core/src/test/java/org/apache/wicket/BehaviorUrlTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/BehaviorUrlTest.java
@@ -151,7 +151,7 @@ public class BehaviorUrlTest extends WicketTestCase
 		tester.startPage(EscapeTestPage.class);
 
 		String response = tester.getLastResponseAsString();
-		System.err.println(response);
+//		System.err.println(response);
 		assertTrue(response.contains(EscapeTestPage.TEST_QUERY_STRING));
 
 		tester.executeAjaxEvent("form:textfield", "onchange");

http://git-wip-us.apache.org/repos/asf/wicket/blob/b36939b3/wicket-devutils/src/main/java/org/apache/wicket/devutils/diskstore/browser/BrowserPanel.java
----------------------------------------------------------------------
diff --git a/wicket-devutils/src/main/java/org/apache/wicket/devutils/diskstore/browser/BrowserPanel.java b/wicket-devutils/src/main/java/org/apache/wicket/devutils/diskstore/browser/BrowserPanel.java
index 27c7a1c..accc825 100644
--- a/wicket-devutils/src/main/java/org/apache/wicket/devutils/diskstore/browser/BrowserPanel.java
+++ b/wicket-devutils/src/main/java/org/apache/wicket/devutils/diskstore/browser/BrowserPanel.java
@@ -86,7 +86,7 @@ public class BrowserPanel extends Panel
 		currentSessionLink.setOutputMarkupPlaceholderTag(true);
 		add(currentSessionLink);
 
-		sessionsSelector.add(new AjaxFormComponentUpdatingBehavior("onchange")
+		sessionsSelector.add(new AjaxFormComponentUpdatingBehavior("change")
 		{
 			@Override
 			protected void onUpdate(AjaxRequestTarget target)

http://git-wip-us.apache.org/repos/asf/wicket/blob/b36939b3/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/ChoicePage.java
----------------------------------------------------------------------
diff --git a/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/ChoicePage.java b/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/ChoicePage.java
index 356635c..d612cb0 100644
--- a/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/ChoicePage.java
+++ b/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/ChoicePage.java
@@ -107,7 +107,7 @@ public class ChoicePage extends BasePage
 		form.add(makes);
 		form.add(models);
 
-		makes.add(new AjaxFormComponentUpdatingBehavior("onchange")
+		makes.add(new AjaxFormComponentUpdatingBehavior("change")
 		{
 			@Override
 			protected void onUpdate(AjaxRequestTarget target)

http://git-wip-us.apache.org/repos/asf/wicket/blob/b36939b3/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/tree/EditablePanel.java
----------------------------------------------------------------------
diff --git a/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/tree/EditablePanel.java b/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/tree/EditablePanel.java
index df480db..5a9722c 100644
--- a/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/tree/EditablePanel.java
+++ b/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/tree/EditablePanel.java
@@ -39,14 +39,14 @@ public class EditablePanel extends Panel
 	 * @param inputModel
 	 *            Model of the text field
 	 */
-	public EditablePanel(String id, IModel inputModel)
+	public EditablePanel(String id, IModel<?> inputModel)
 	{
 		super(id);
 
-		TextField field = new TextField("textfield", inputModel);
+		TextField<?> field = new TextField("textfield", inputModel);
 		add(field);
 
-		field.add(new AjaxFormComponentUpdatingBehavior("onblur")
+		field.add(new AjaxFormComponentUpdatingBehavior("blur")
 		{
 			@Override
 			protected void onUpdate(AjaxRequestTarget target)