You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/06/21 14:59:04 UTC
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request
#2727: ARTEMIS-2394 Improve scheduling sync for AMQPConnectionContext
franz1981 commented on a change in pull request #2727: ARTEMIS-2394 Improve scheduling sync for AMQPConnectionContext
URL: https://github.com/apache/activemq-artemis/pull/2727#discussion_r296271096
##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
##########
@@ -87,9 +88,7 @@
private final boolean useCoreSubscriptionNaming;
- private boolean isSchedulingCancelled;
- private ScheduledFuture scheduledFuture;
- private final Object schedulingLock = new Object();
+ private AtomicReference scheduledFutureRef;
Review comment:
make it final and it would be better to use the not raw version by using <>. You can always create a singleton instance to be used to do your logic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services