You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/10 16:21:10 UTC

[GitHub] maryannxue commented on a change in pull request #23507: [SPARK-26576][SQL] Broadcast hint not applied to partitioned table

maryannxue commented on a change in pull request #23507: [SPARK-26576][SQL] Broadcast hint not applied to partitioned table
URL: https://github.com/apache/spark/pull/23507#discussion_r246825492
 
 

 ##########
 File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruneFileSourcePartitionsSuite.scala
 ##########
 @@ -91,4 +92,16 @@ class PruneFileSourcePartitionsSuite extends QueryTest with SQLTestUtils with Te
       assert(size2 < tableStats.get.sizeInBytes)
     }
   }
+
+  test("SPARK-26576 Broadcast hint not applied to partitioned table") {
+    withTable("tbl") {
+      spark.range(10).selectExpr("id", "id % 3 as p").write.partitionBy("p").saveAsTable("tbl")
+
+      val df = spark.table("tbl")
+      val hints = df.join(broadcast(df), "p").queryExecution.optimizedPlan.collect {
 
 Review comment:
   +1. And since master doesn't use ResolvedHint in optimization anymore, this issue doesn't exist in master, but figured out it wouldn't hurt to add a test in master too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org