[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3833: [improve] Enhance LedgerFragment toString method

["hangc0276 (via GitHub)" <gi...@apache.org>]

hangc0276 commented on code in PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#discussion_r1184523292


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java:
##########
@@ -229,15 +229,16 @@ public void setReplicateType(ReplicateType replicateType) {
     @Override
     public String toString() {
         return String.format("Fragment(LedgerID: %d, FirstEntryID: %d[%d], "
-                + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s)", ledgerId, firstEntryId,
+                + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s, Type: %s)", ledgerId, firstEntryId,
                 getFirstStoredEntryId(), lastKnownEntryId, getLastStoredEntryId(),
-                getAddresses(), isLedgerClosed);
+                getAddresses(), isLedgerClosed, replicateType);
     }
 
     /**
      * ReplicateType.
      */
     public enum ReplicateType {
+        NULL,

Review Comment:
   Would you please explain why adding the `NULL` state and what's the meaning of the `NULL` replication type? I found the all code parts are related to `DATA_LOSS` or `DATA_NOT_ADHERING_PLACEMENT`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org