You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/11 00:39:19 UTC

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #3790: MINOR: Benchmark regression tests

andygrove opened a new pull request, #3790:
URL: https://github.com/apache/arrow-datafusion/pull/3790

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   N/A
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   In an effort to prevent regressions creeping into the planner or optimizer, this PR adds tests for the expected plans for each benchmark query.
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Tests
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   No
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #3790: MINOR: Benchmark regression tests

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3790:
URL: https://github.com/apache/arrow-datafusion/pull/3790#issuecomment-1274636034

   Will likely help with issues such as https://github.com/apache/arrow-datafusion/issues/3729


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #3790: MINOR: Benchmark regression tests

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #3790:
URL: https://github.com/apache/arrow-datafusion/pull/3790#issuecomment-1274668207

   Thanks for the reviews @alamb and @yjshen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #3790: MINOR: Benchmark regression tests

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3790:
URL: https://github.com/apache/arrow-datafusion/pull/3790#issuecomment-1274634940

   Thanks @andygrove  -- this is perfect


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove merged pull request #3790: MINOR: Benchmark regression tests

Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3790:
URL: https://github.com/apache/arrow-datafusion/pull/3790


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ursabot commented on pull request #3790: MINOR: Benchmark regression tests

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3790:
URL: https://github.com/apache/arrow-datafusion/pull/3790#issuecomment-1274679698

   Benchmark runs are scheduled for baseline = e359f02c5392a0706218f578311c9290a3550392 and contender = a9ee67471d1ab0ad11f12d024315b3a824d6101f. a9ee67471d1ab0ad11f12d024315b3a824d6101f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/fa754cffd9104ef08511dfe6caa889f2...0a7eef76f9874d74bda5ef490e280339/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/848e9abde87a4587a22925f471c7d29c...dabf41cdbab64f02babb1d2c2cd0c490/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8d6f6857f48c4e87ab39632cdc65daf4...fa01125b9e8149308f933fff5cab41f8/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9074c510ad934e55b9bc8e99fd47b359...743a0a9c74d542718e489c311ea81b62/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org