[GitHub] [spark] HeartSaVioR edited a comment on pull request #30366: [SPARK-33440][CORE] Separate the calculation for the next renewal date for each delegation token

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on pull request #30366:
URL: https://github.com/apache/spark/pull/30366#issuecomment-726531257


   Another possible improvement (though I'm not 100% sure about the risk) would be considering `issue date` as current timestamp when the value is 0L (default). This might calculate the interval smaller than the actual (hence the risk), but as we fetch the token before doing the calculation (please correct me if I'm missing here), the alternative won't be too skewed.
   
   This improvement is also helpful to address another possible issue where the problematic token identifier is solely used. Spark will correctly calculates the next renewal date for the first time (min interval is actually expired date so it's going to be correct after adding 0L), but Spark also caches the interval which is "unchanged", and adding 0L to the cached interval won't change the next renewal date, hence eventually it will be earlier than current timestamp, triggering the same problem.
   
   Please review the additional possible improvement as well. I'll incorporate it once reviewers double-check about the idea and say it's OK to go.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org