You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/08/07 23:17:36 UTC
Review Request 71244: Included task group's resources in the
ExecutorInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71244/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9925
https://issues.apache.org/jira/browse/MESOS-9925
Repository: mesos
Description
-------
Included task group's resources in the ExecutorInfo.
Diffs
-----
src/slave/slave.cpp 74eb45744d6603b91676e812ed008a7b1ab39a49
Diff: https://reviews.apache.org/r/71244/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 71244: Included task group's resources in the
ExecutorInfo.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71244/#review217113
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71244]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 7, 2019, 11:17 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71244/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2019, 11:17 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9925
> https://issues.apache.org/jira/browse/MESOS-9925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included task group's resources in the ExecutorInfo.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 74eb45744d6603b91676e812ed008a7b1ab39a49
>
>
> Diff: https://reviews.apache.org/r/71244/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71244: Included task group's resources in the
ExecutorInfo.
Posted by Qian Zhang <zh...@gmail.com>.
> On Aug. 9, 2019, 1:23 a.m., Vinod Kone wrote:
> > Can you add a test for this?
Sure, I posted a test here: https://reviews.apache.org/r/71287/
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71244/#review217125
-----------------------------------------------------------
On Aug. 14, 2019, 3:52 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71244/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 3:52 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9925
> https://issues.apache.org/jira/browse/MESOS-9925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included task group's resources in the ExecutorInfo.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 74eb45744d6603b91676e812ed008a7b1ab39a49
>
>
> Diff: https://reviews.apache.org/r/71244/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71244: Included task group's resources in the
ExecutorInfo.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71244/#review217125
-----------------------------------------------------------
Can you add a test for this?
src/slave/slave.cpp
Lines 3120 (patched)
<https://reviews.apache.org/r/71244/#comment304392>
s/taskResources/tasksResources/
- Vinod Kone
On Aug. 7, 2019, 11:17 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71244/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2019, 11:17 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9925
> https://issues.apache.org/jira/browse/MESOS-9925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included task group's resources in the ExecutorInfo.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 74eb45744d6603b91676e812ed008a7b1ab39a49
>
>
> Diff: https://reviews.apache.org/r/71244/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71244: Included task group's resources in the
ExecutorInfo.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71244/#review217230
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Aug. 14, 2019, 12:52 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71244/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 12:52 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9925
> https://issues.apache.org/jira/browse/MESOS-9925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included task group's resources in the ExecutorInfo.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 74eb45744d6603b91676e812ed008a7b1ab39a49
>
>
> Diff: https://reviews.apache.org/r/71244/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71244: Included task group's resources in the
ExecutorInfo.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71244/
-----------------------------------------------------------
(Updated Aug. 14, 2019, 3:52 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Changes
-------
Addressed review comments.
Bugs: MESOS-9925
https://issues.apache.org/jira/browse/MESOS-9925
Repository: mesos
Description
-------
Included task group's resources in the ExecutorInfo.
Diffs (updated)
-----
src/slave/slave.cpp 74eb45744d6603b91676e812ed008a7b1ab39a49
Diff: https://reviews.apache.org/r/71244/diff/2/
Changes: https://reviews.apache.org/r/71244/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang