You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2023/01/13 02:02:19 UTC

[GitHub] [commons-imaging] Glavo opened a new pull request, #269: [WIP] Support PNG extension

Glavo opened a new pull request, #269:
URL: https://github.com/apache/commons-imaging/pull/269

   I hope to support [Extensions to the PNG 1.2 Specification, Version 1.5.0](http://ftp-osl.osuosl.org/pub/libpng/documents/pngext-1.5.0.html) in this PR and be ready to support APNG in subsequent PR.
   
   Some completed work:
   
   * Add an enum representing the PNG extension type;
   * Refactoring `PngImageParser::readChunks` and `ChunkType` to improve maintainability makes it easier to add new Chunk types later;
   * Support reading EXIF from PNG images.
   
   Things still need to be done:
   
   * Merge EXIF into PNG metadata;
   * Think about where extensions chunk types should be placed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [IMAGING-340] Support PNG extension [commons-imaging]

Posted by "kinow (via GitHub)" <gi...@apache.org>.

kinow commented on PR #269:
URL: https://github.com/apache/commons-imaging/pull/269#issuecomment-1966358868

   I understand the frustration @StefanOltmann , and I am sure there are ways to improve how we interact here (on both ends, including myself). I have not followed everything that's happening due to these $work projects/deadlines, but I will try to catch up with everything that is happening and slowly start to review issues and pull requests, and also fix the security warnings we have.
   
   Feel free to ping me in issues/pull requests if you'd like, just expect some delays until the end of this month :+1: And as for your interaction with Gary/others, please consider that they are trying to help as I was the last person more actively working, but I have been away for some months now (apologies, again). They are trying to help as much as they can, and there can be some misunderstanding, but finding a way to work well and communicate your frustrations clearly and politely is key -- not only for ASF, but for your own personal open source projects :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [IMAGING-340] Support PNG extension [commons-imaging]

Posted by "StefanOltmann (via GitHub)" <gi...@apache.org>.

StefanOltmann commented on PR #269:
URL: https://github.com/apache/commons-imaging/pull/269#issuecomment-1966197969

@kinow

Thank you for reaching out and providing an update.

I must admit, I've encountered some frustration recently. Over the past few months, the only noticeable activity on the project seems to be from Gary, who has been addressing minor style issues but not significantly contributing otherwise. It appears he hasn't been thoroughly reviewing code in pull requests and may not grasp the project's domain.

Even without unit tests, confirming the correctness of the bugfix in my pull request or validating the provided test should have been straightforward for someone familiar with the codebase and its intricacies. This is the kind of scrutiny and understanding that someone actively engaged in the project could provide.

I recall observing this level of engagement from you some time ago, which is why I directed my concerns to you.

Maybe the project isn’t dead, given the abundance of open issues and pull requests coupled with the lack of substantial development, it's difficult to characterize it as an actively progressing endeavor.

I am glad to hear that you plan to pick up the work here, because this project deserves real maintenance.

How Gary acts on my PRs is just ridiculous. First he wanted me to include a test image and provide a test - both would not have been necessary. After I did go the extra mile he doesn’t want the test (because he does not seem to understand what it does) and now all of the sudden the inclusion of the test image is a problem. That’s really sad and ridiculous maintenance. I believe this projects deserves better.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org