You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Andrey Kuznetsov (JIRA)" <ji...@apache.org> on 2018/09/21 13:57:00 UTC

[jira] [Comment Edited] (IGNITE-9660) Switch default test FailureHandler to StopNodeFailureHandler

    [ https://issues.apache.org/jira/browse/IGNITE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623651#comment-16623651 ] 

Andrey Kuznetsov edited comment on IGNITE-9660 at 9/21/18 1:56 PM:
-------------------------------------------------------------------

It's better to use special test-scope failure handler instead of {{StopNodeFailureHandler}}. That handler mentioned in [1] should fail current test method as graceful as possible.

[1] https://issues.apache.org/jira/browse/IGNITE-8227


was (Author: andrey-kuznetsov):
It's better to use special test-scope failure handler instead of {{StopNodeFailureHandler}}. That handler should fail current test method as graceful as possible.

> Switch default test FailureHandler to StopNodeFailureHandler
> ------------------------------------------------------------
>
>                 Key: IGNITE-9660
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9660
>             Project: Ignite
>          Issue Type: Task
>    Affects Versions: 2.6
>            Reporter: Andrey Kuznetsov
>            Priority: Major
>             Fix For: 2.8
>
>
> {{GridAbstractTest.getFailureHandler()}} returns {{NoOpFailureHandler}} instance. This often leads to hiding bugs occurring in tests. {{getFailureFailureHandler()}} should return {{StopNodeFailureHandler}} instead.
> The change assumes re-checking failed tests and set handler to {{NoOpFailureHandler}} in subclasses where it's really a must.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)