You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/14 05:37:12 UTC
[GitHub] [airflow] jlaneve opened a new pull request #15840: Fix docstring formatting on SlackHook
jlaneve opened a new pull request #15840:
URL: https://github.com/apache/airflow/pull/15840
Fixes formatting on SlackHook's docstring to adhere to Sphinx standards. See [the Airflow docs](https://airflow.apache.org/docs/apache-airflow-providers-slack/1.0.0/_api/airflow/providers/slack/hooks/slack/index.html) for the current rendering - the short description is currently:
"Creates a Slack connection, to be used for calls. Takes both Slack API token directly and connection that has Slack API token. If both supplied, Slack API token will be used. Exposes also the rest of slack.WebClient args **Examples**:"
Also fixes minor grammatical issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jlaneve commented on pull request #15840: Fix docstring formatting on SlackHook
Posted by GitBox <gi...@apache.org>.
jlaneve commented on pull request #15840:
URL: https://github.com/apache/airflow/pull/15840#issuecomment-841418113
@potiuk I think they're fixed now but there's one task still failing. I can't tell what the error is / if it's caused by my fix. It doesn't make sense that it would be given it's a Postgres failure but can you confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Dr-Denzy commented on pull request #15840: Fix docstring formatting on SlackHook
Posted by GitBox <gi...@apache.org>.
Dr-Denzy commented on pull request #15840:
URL: https://github.com/apache/airflow/pull/15840#issuecomment-841121653
If you are using VS Code, you can use `black` to reformat the file and that should fix the static check error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15840: Fix docstring formatting on SlackHook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15840:
URL: https://github.com/apache/airflow/pull/15840#issuecomment-841085323
You need reformat the files - staic checks are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15840: Fix docstring formatting on SlackHook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15840:
URL: https://github.com/apache/airflow/pull/15840#issuecomment-841022342
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #15840: Fix docstring formatting on SlackHook
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #15840:
URL: https://github.com/apache/airflow/pull/15840#issuecomment-841124249
Or even better. Run `pre-commit install` and it will be automatically fixed for you when you run `git commit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15840: Fix docstring formatting on SlackHook
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15840:
URL: https://github.com/apache/airflow/pull/15840#issuecomment-841419802
Thanks @jlaneve for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15840: Fix docstring formatting on SlackHook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15840:
URL: https://github.com/apache/airflow/pull/15840#issuecomment-841124249
Ore even better. Run `pre-commit install` and it will be automatically fixed for you when you run `git commit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15840: Fix docstring formatting on SlackHook
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15840:
URL: https://github.com/apache/airflow/pull/15840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org