You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/07/07 06:23:04 UTC

[GitHub] [ratis] lanicc opened a new pull request, #672: RATIS-1615. Server should support listening on a specified network address

lanicc opened a new pull request, #672:
URL: https://github.com/apache/ratis/pull/672

   ## What changes were proposed in this pull request?
   
   Server should support listening on a specified network address
   
   ## What is the link to the Apache JIRA
   
   [RATIS-1615](https://issues.apache.org/jira/browse/RATIS-1615)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] lanicc commented on pull request #672: RATIS-1615. Server should support listening on a specified network address

Posted by GitBox <gi...@apache.org>.
lanicc commented on PR #672:
URL: https://github.com/apache/ratis/pull/672#issuecomment-1177158037

   Grpcservice also has this problem. Its constructor contains too many parameters so that I do not have a good idea to fix it.
   Does anyone have a good idea
   
   https://github.com/apache/ratis/blob/c320f93c5a510f07933536e28e507ef9c3ba3531/ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcService.java#L133
   
   ```
     @SuppressWarnings("checkstyle:ParameterNumber") // private constructor
     private GrpcService(RaftServer raftServer, Supplier<RaftPeerId> idSupplier,
         int adminPort, GrpcTlsConfig adminTlsConfig,
         int clientPort, GrpcTlsConfig clientTlsConfig,
         int serverPort, GrpcTlsConfig serverTlsConfig,
         SizeInBytes grpcMessageSizeMax, SizeInBytes appenderBufferSize,
         SizeInBytes flowControlWindow,TimeDuration requestTimeoutDuration) {
      ...
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo merged pull request #672: RATIS-1615. Server should support listening on a specified network address

Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #672:
URL: https://github.com/apache/ratis/pull/672


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org