You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Colin Ma <ju...@intel.com> on 2015/11/12 07:27:54 UTC
Review Request 40216: SQOOP-2682: Sqoop2: Add test cases for the
object name with special char
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40216/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Add test cases for the object name with special char, eg, "." , "/", "?", "&" etc.
Diffs
-----
test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java 811315a
Diff: https://reviews.apache.org/r/40216/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 40216: SQOOP-2682: Sqoop2: Add test cases for the
object name with special char
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40216/#review106888
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Nov. 16, 2015, 6:07 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40216/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 6:07 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Add test cases for the object name with special char, eg, "." , "/", "?", "&" etc.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 488318e
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java bc6e0a9
> test/src/test/java/org/apache/sqoop/integration/connector/hdfs/InformalJobNameExecuteTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java 16480c3
>
> Diff: https://reviews.apache.org/r/40216/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 40216: SQOOP-2682: Sqoop2: Add test cases for the
object name with special char
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40216/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 6:07 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Add test cases for the object name with special char, eg, "." , "/", "?", "&" etc.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 488318e
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java bc6e0a9
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/InformalJobNameExecuteTest.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java 16480c3
Diff: https://reviews.apache.org/r/40216/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 40216: SQOOP-2682: Sqoop2: Add test cases for the
object name with special char
Posted by Colin Ma <ju...@intel.com>.
> On Nov. 12, 2015, 7:47 p.m., Jarek Cecho wrote:
> > Thank you for the work here Colin! I have couple of high level comments:
> >
> > 1) It seems that we have many dimensions that we want to try. Rather then using the generic methods, can we make the test parametrized in the same way we have other similar tests? Look at PartitionerTest as an example [1].
> >
> > 2) Since now there is not "backup" solution in case of id, can we be more exhasive in the tests? Let's try all create/update/delete/read on jobs/links and start/stop/status on submissions.
> >
> > Links:
> > 1: https://github.com/apache/sqoop/blob/sqoop2/test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java
For point 1, I'll update the test.
For point 2, you're right, we need test all the public interface with the name. I already fixed 3 bugs, still work on this. Thanks for reminder!!!
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40216/#review106316
-----------------------------------------------------------
On Nov. 12, 2015, 6:27 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40216/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 6:27 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Add test cases for the object name with special char, eg, "." , "/", "?", "&" etc.
>
>
> Diffs
> -----
>
> test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java 811315a
>
> Diff: https://reviews.apache.org/r/40216/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 40216: SQOOP-2682: Sqoop2: Add test cases for the
object name with special char
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40216/#review106316
-----------------------------------------------------------
Thank you for the work here Colin! I have couple of high level comments:
1) It seems that we have many dimensions that we want to try. Rather then using the generic methods, can we make the test parametrized in the same way we have other similar tests? Look at PartitionerTest as an example [1].
2) Since now there is not "backup" solution in case of id, can we be more exhasive in the tests? Let's try all create/update/delete/read on jobs/links and start/stop/status on submissions.
Links:
1: https://github.com/apache/sqoop/blob/sqoop2/test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java
- Jarek Cecho
On Nov. 12, 2015, 6:27 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40216/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 6:27 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Add test cases for the object name with special char, eg, "." , "/", "?", "&" etc.
>
>
> Diffs
> -----
>
> test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java 811315a
>
> Diff: https://reviews.apache.org/r/40216/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>