You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/03/15 02:38:57 UTC
Review Request 66076: Used raw string literal in protobuf tests to
avoid escaping.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66076/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao.
Repository: mesos
Description
-------
Used raw string literal in protobuf tests to avoid escaping.
Diffs
-----
3rdparty/stout/tests/protobuf_tests.cpp a0ef1d110204fe2868ac9b686da090d9e7b3d2a3
Diff: https://reviews.apache.org/r/66076/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 66076: Used raw string literal in protobuf tests
to avoid escaping.
Posted by Qian Zhang <zh...@gmail.com>.
> On March 17, 2018, 5:40 a.m., Chun-Hung Hsiao wrote:
> > 3rdparty/stout/tests/protobuf_tests.cpp
> > Line 108 (original), 108 (patched)
> > <https://reviews.apache.org/r/66076/diff/2/?file=1976427#file1976427line108>
> >
> > Not sure what style is better. How about
> > ```
> > string expected = R"~({
> > ...
> > })~";
> > ```
> > Or
> > ```
> > string expceted =
> > R"~({
> > ...
> > })~";
> > ```
> > ?
Yeah, I think the later is better, but usually we do not put `R"~(` and `{` in the same line, see `docker_spec_tests.cpp` and `appc_spec_tests.cpp` as example.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66076/#review199349
-----------------------------------------------------------
On March 15, 2018, 5:29 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66076/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 5:29 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used raw string literal in protobuf tests to avoid escaping.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp a0ef1d110204fe2868ac9b686da090d9e7b3d2a3
>
>
> Diff: https://reviews.apache.org/r/66076/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66076: Used raw string literal in protobuf tests
to avoid escaping.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66076/#review199349
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/stout/tests/protobuf_tests.cpp
Line 108 (original), 108 (patched)
<https://reviews.apache.org/r/66076/#comment279652>
Not sure what style is better. How about
```
string expected = R"~({
...
})~";
```
Or
```
string expceted =
R"~({
...
})~";
```
?
- Chun-Hung Hsiao
On March 15, 2018, 9:29 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66076/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 9:29 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used raw string literal in protobuf tests to avoid escaping.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp a0ef1d110204fe2868ac9b686da090d9e7b3d2a3
>
>
> Diff: https://reviews.apache.org/r/66076/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66076: Used raw string literal in protobuf tests
to avoid escaping.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66076/
-----------------------------------------------------------
(Updated March 23, 2018, 9:12 a.m.)
Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao.
Changes
-------
Addressed review comments.
Repository: mesos
Description
-------
Used raw string literal in protobuf tests to avoid escaping.
Diffs (updated)
-----
3rdparty/stout/tests/protobuf_tests.cpp a0ef1d110204fe2868ac9b686da090d9e7b3d2a3
Diff: https://reviews.apache.org/r/66076/diff/3/
Changes: https://reviews.apache.org/r/66076/diff/2-3/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 66076: Used raw string literal in protobuf tests
to avoid escaping.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66076/#review199285
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66076]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 15, 2018, 9:29 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66076/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 9:29 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used raw string literal in protobuf tests to avoid escaping.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp a0ef1d110204fe2868ac9b686da090d9e7b3d2a3
>
>
> Diff: https://reviews.apache.org/r/66076/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66076: Used raw string literal in protobuf tests
to avoid escaping.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66076/#review199252
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66076']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66076
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66076/logs/libprocess-tests-stdout.log):
```
[ RUN ] TimeTest.Output
[ OK ] TimeTest.Output (0 ms)
[----------] 4 tests from TimeTest (6 ms total)
[----------] 3 tests from TimeSeriesTest
[ RUN ] TimeSeriesTest.Set
[ OK ] TimeSeriesTest.Set (0 ms)
[ RUN ] TimeSeriesTest.Sparsify
[ OK ] TimeSeriesTest.Sparsify (1 ms)
[ RUN ] TimeSeriesTest.Truncate
[ OK ] TimeSeriesTest.Truncate (2 ms)
[----------] 3 tests from TimeSeriesTest (7 ms total)
[----------] 3 tests from JWTTest
[ RUN ] JWTTest.Parse
[ OK ] JWTTest.Parse (8 ms)
[ RUN ] JWTTest.Create
[ OK ] JWTTest.Create (1 ms)
[ RUN ] JWTTest.Stringify
[ OK ] JWTTest.Stringify (1 ms)
[----------] 3 tests from JWTTest (12 ms total)
[----------] 1 test from SSL
[ RUN ] SSL.Disabled
[ OK ] SSL.Disabled (10 ms)
[----------] 1 test from SSL (10 ms total)
[----------] 17 tests from SSLTest
[ RUN ] SSLTest.SSLSocket
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66076/logs/libprocess-tests-stderr.log):
```
ABORT: (D:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp:171): Could not generate certificate: Failed to set common name: X509_NAME_add_entry_by_txt
```
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66076/logs/mesos-tests-stdout.log):
```
[ OK ] ContentType/SchedulerTest.Revive/1 (264 ms)
[ RUN ] ContentType/SchedulerTest.Suppress/0
[ OK ] ContentType/SchedulerTest.Suppress/0 (260 ms)
[ RUN ] ContentType/SchedulerTest.Suppress/1
[ OK ] ContentType/SchedulerTest.Suppress/1 (263 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0
[ OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0 (270 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1
[ OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1 (283 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0
[ OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0 (320 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1
[ OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1 (328 ms)
[ RUN ] ContentType/SchedulerTest.Message/0
[ OK ] ContentType/SchedulerTest.Message/0 (329 ms)
[ RUN ] ContentType/SchedulerTest.Message/1
[ OK ] ContentType/SchedulerTest.Message/1 (351 ms)
[ RUN ] ContentType/SchedulerTest.Request/0
[ OK ] ContentType/SchedulerTest.Request/0 (105 ms)
[ RUN ] ContentType/SchedulerTest.Request/1
[ OK ] ContentType/SchedulerTest.Request/1 (109 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (90 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (93 ms)
[----------] 32 tests from ContentType/SchedulerTest (18028 ms total)
[----------] 4 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66076/logs/mesos-tests-stderr.log):
```
I0315 10:27:02.801738 11980 master.cpp:1792] Recovered 0 agents from the registry (239B); allowing 10mins for agents to reregister
I0315 10:27:02.810734 6664 scheduler.cpp:188] Version: 1.6.0
I0315 10:27:02.810734 11832 scheduler.cpp:311] Using default 'basic' HTTP authenticatee
I0315 10:27:02.811731 11180 scheduler.cpp:494] New master detected at master@10.3.1.8:65020
I0315 10:27:02.820724 7916 scheduler.cpp:468] Re-detecting master
I0315 10:27:02.822723 7916 scheduler.cpp:494] New master detected at master@10.3.1.8:65020
I0315 10:27:02.829726 8284 scheduler.cpp:472] Lost leading master
I0315 10:27:02.835732 6664 master.cpp:1136] Master terminating
I0315 10:27:02.860736 6664 cluster.cpp:172] Creating default 'local' authorizer
I0315 10:27:02.869735 7916 master.cpp:463] Master b92634ab-c49d-4730-a700-dd7ba44a6f5a (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 10.3.1.8:65020
I0315 10:27:02.869735 7916 master.cpp:465] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\0frF84\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_memory"
--registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --require_agent_domain="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\0frF84\master" --zk_session_timeout="10secs"
I0315 10:27:02.872735 7916 master.cpp:514] Master only allowing authenticated frameworks to register
I0315 10:27:02.872735 7916 master.cpp:520] Master only allowing authenticated agents to register
I0315 10:27:02.872735 7916 master.cpp:526] Master only allowing authenticated HTTP frameworks to register
I0315 10:27:02.873734 7916 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\0frF84\credentials'
I0315 10:27:02.874734 7916 master.cpp:570] Using default 'crammd5' authenticator
I0315 10:27:02.875735 7916 http.cpp:957] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I0315 10:27:02.875735 7916 http.cpp:957] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I0315 10:27:02.876734 7916 http.cpp:957] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I0315 10:27:02.877724 7916 master.cpp:649] Authorization enabled
I0315 10:27:02.887734 2736 master.cpp:2119] Elected as the leading master!
I0315 10:27:02.888736 2736 master.cpp:1678] Recovering from registrar
I0315 10:27:02.889735 5984 registrar.cpp:391] Successfully fetched the registry (0B) in 999936ns
I0315 10:27:02.889735 5984 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I0315 10:27:02.890735 5984 registrar.cpp:552] Successfully updated the registry in 1.000192ms
I0315 10:27:02.891727 5984 registrar.cpp:424] Successfully recovered registrar
I0315 10:27:02.892735 11180 master.cpp:1792] Recovered 0 agents from the registry (239B); allowing 10mins for agents to reregister
I0315 10:27:02.900737 6664 scheduler.cpp:188] Version: 1.6.0
I0315 10ABORT: (D:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp:171): Could not generate certificate: Failed to set common name: X509_NAME_add_entry_by_txt
```
- Mesos Reviewbot Windows
On March 15, 2018, 2:59 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66076/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 2:59 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used raw string literal in protobuf tests to avoid escaping.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp a0ef1d110204fe2868ac9b686da090d9e7b3d2a3
>
>
> Diff: https://reviews.apache.org/r/66076/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66076: Used raw string literal in protobuf tests
to avoid escaping.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66076/
-----------------------------------------------------------
(Updated March 15, 2018, 5:29 p.m.)
Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao.
Changes
-------
Changed the solution from `strings::remove` to `std::remove_if`.
Repository: mesos
Description
-------
Used raw string literal in protobuf tests to avoid escaping.
Diffs (updated)
-----
3rdparty/stout/tests/protobuf_tests.cpp a0ef1d110204fe2868ac9b686da090d9e7b3d2a3
Diff: https://reviews.apache.org/r/66076/diff/2/
Changes: https://reviews.apache.org/r/66076/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 66076: Used raw string literal in protobuf tests
to avoid escaping.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66076/#review199244
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66076']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66076
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66076/logs/libprocess-tests-stdout.log):
```
[ RUN ] TimeTest.Output
[ OK ] TimeTest.Output (0 ms)
[----------] 4 tests from TimeTest (5 ms total)
[----------] 3 tests from TimeSeriesTest
[ RUN ] TimeSeriesTest.Set
[ OK ] TimeSeriesTest.Set (0 ms)
[ RUN ] TimeSeriesTest.Sparsify
[ OK ] TimeSeriesTest.Sparsify (1 ms)
[ RUN ] TimeSeriesTest.Truncate
[ OK ] TimeSeriesTest.Truncate (2 ms)
[----------] 3 tests from TimeSeriesTest (8 ms total)
[----------] 3 tests from JWTTest
[ RUN ] JWTTest.Parse
[ OK ] JWTTest.Parse (11 ms)
[ RUN ] JWTTest.Create
[ OK ] JWTTest.Create (1 ms)
[ RUN ] JWTTest.Stringify
[ OK ] JWTTest.Stringify (1 ms)
[----------] 3 tests from JWTTest (28 ms total)
[----------] 1 test from SSL
[ RUN ] SSL.Disabled
[ OK ] SSL.Disabled (9 ms)
[----------] 1 test from SSL (10 ms total)
[----------] 17 tests from SSLTest
[ RUN ] SSLTest.SSLSocket
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66076/logs/libprocess-tests-stderr.log):
```
ABORT: (D:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp:171): Could not generate certificate: Failed to set common name: X509_NAME_add_entry_by_txt
```
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66076/logs/mesos-tests-stdout.log):
```
[ OK ] ContentType/SchedulerTest.Revive/1 (259 ms)
[ RUN ] ContentType/SchedulerTest.Suppress/0
[ OK ] ContentType/SchedulerTest.Suppress/0 (250 ms)
[ RUN ] ContentType/SchedulerTest.Suppress/1
[ OK ] ContentType/SchedulerTest.Suppress/1 (286 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0
[ OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0 (263 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1
[ OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1 (289 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0
[ OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0 (310 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1
[ OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1 (336 ms)
[ RUN ] ContentType/SchedulerTest.Message/0
[ OK ] ContentType/SchedulerTest.Message/0 (327 ms)
[ RUN ] ContentType/SchedulerTest.Message/1
[ OK ] ContentType/SchedulerTest.Message/1 (341 ms)
[ RUN ] ContentType/SchedulerTest.Request/0
[ OK ] ContentType/SchedulerTest.Request/0 (103 ms)
[ RUN ] ContentType/SchedulerTest.Request/1
[ OK ] ContentType/SchedulerTest.Request/1 (107 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (85 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (86 ms)
[----------] 32 tests from ContentType/SchedulerTest (16842 ms total)
[----------] 4 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66076/logs/mesos-tests-stderr.log):
```
I0315 03:36:25.695457 13804 master.cpp:1678] Recovering from registrar
I0315 03:36:25.697437 7632 registrar.cpp:391] Successfully fetched the registry (0B) in 963840ns
I0315 03:36:25.697437 7632 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I0315 03:36:25.698453 7632 registrar.cpp:552] Successfully updated the registry in 1.017088ms
I0315 03:36:25.699432 7632 registrar.cpp:424] Successfully recovered registrar
I0315 03:36:25.700461 12664 master.cpp:1792] Recovered 0 agents from the registry (239B); allowing 10mins for agents to reregister
I0315 03:36:25.707435 4240 scheduler.cpp:188] Version: 1.6.0
I0315 03:36:25.708436 10772 scheduler.cpp:311] Using default 'basic' HTTP authenticatee
I0315 03:36:25.708436 10804 scheduler.cpp:494] New master detected at master@10.3.1.8:62900
I0315 03:36:25.716439 13804 scheduler.cpp:468] Re-detecting master
I0315 03:36:25.718420 13804 scheduler.cpp:494] New master detected at master@10.3.1.8:62900
I0315 03:36:25.726431 4556 scheduler.cpp:472] Lost leading master
I0315 03:36:25.731449 4240 master.cpp:1136] Master terminating
I0315 03:36:25.756440 4240 cluster.cpp:172] Creating default 'local' authorizer
I0315 03:36:25.764430 11236 master.cpp:463] Master 351272f1-dcbb-46f8-af3d-72de109d8709 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 10.3.1.8:62900
I0315 03:36:25.764430 11236 master.cpp:465] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\l7VFDh\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_memory"
--registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --require_agent_domain="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\l7VFDh\master" --zk_session_timeout="10secs"
I0315 03:36:25.766423 11236 master.cpp:514] Master only allowing authenticated frameworks to register
I0315 03:36:25.766423 11236 master.cpp:520] Master only allowing authenticated agents to register
I0315 03:36:25.767432 11236 master.cpp:526] Master only allowing authenticated HTTP frameworks to register
I0315 03:36:25.767432 11236 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\l7VFDh\credentials'
I0315 03:36:25.768424 11236 master.cpp:570] Using default 'crammd5' authenticator
I0315 03:36:25.769423 11236 http.cpp:957] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I0315 03:36:25.769423 11236 http.cpp:957] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I0315 03:36:25.770431 11236 http.cpp:957] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I0315 03:36:25.771428 11236 master.cpp:649] Authorization enabled
I0315 03:36:25.782424 10772 master.cpp:2119] Elected as the leading master!
I0315 03:36:25.782424 10772 master.cpp:1678] Recovering from registrar
I0315 03:36:25.783478 6776 registrar.cpp:391] Successfully fetched the registry (0B) in 1.053952ms
I03ABORT: (D:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp:171): Could not generate certificate: Failed to set common name: X509_NAME_add_entry_by_txt
```
- Mesos Reviewbot Windows
On March 15, 2018, 2:38 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66076/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 2:38 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used raw string literal in protobuf tests to avoid escaping.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp a0ef1d110204fe2868ac9b686da090d9e7b3d2a3
>
>
> Diff: https://reviews.apache.org/r/66076/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>