You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "neilconway (via GitHub)" <gi...@apache.org> on 2026/04/18 19:57:36 UTC
[PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
neilconway opened a new pull request, #21722:
URL: https://github.com/apache/datafusion/pull/21722
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on code in PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#discussion_r3106662546
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1338,11 +1338,44 @@ impl SchemaExt for Schema {
}
}
+/// Build a fully-qualified field name string. This is equivalent to
+/// `format!("{q}.{name}")` when `qualifier` is `Some`, or just `name` when
+/// `None`. We avoid going through the `fmt` machinery for performance reasons.
pub fn qualified_name(qualifier: Option<&TableReference>, name: &str) -> String {
- match qualifier {
- Some(q) => format!("{q}.{name}"),
- None => name.to_string(),
- }
+ let qualifier = match qualifier {
+ None => return name.to_string(),
+ Some(q) => q,
+ };
+ let (a, b, c) = match qualifier {
Review Comment:
Can we give names to a/b/c ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#issuecomment-4276063029
run benchmark sql_planner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#issuecomment-4276178718
🤖 Criterion benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21722#issuecomment-4276063029)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
group main neilc_perf-planner-qualified-name
----- ---- ---------------------------------
logical_aggregate_with_join 1.08 440.0±3.43µs ? ?/sec 1.00 409.3±6.31µs ? ?/sec
logical_plan_struct_join_agg_sort 1.03 170.0±1.09µs ? ?/sec 1.00 164.6±0.59µs ? ?/sec
logical_select_all_from_1000 1.05 8.4±0.06ms ? ?/sec 1.00 8.0±0.03ms ? ?/sec
logical_select_one_from_700 1.18 325.5±5.27µs ? ?/sec 1.00 275.6±9.12µs ? ?/sec
logical_trivial_join_high_numbered_columns 1.07 268.6±2.84µs ? ?/sec 1.00 250.7±6.12µs ? ?/sec
logical_trivial_join_low_numbered_columns 1.07 256.1±2.84µs ? ?/sec 1.00 238.3±6.02µs ? ?/sec
physical_intersection 1.07 593.9±1.75µs ? ?/sec 1.00 555.5±1.56µs ? ?/sec
physical_join_consider_sort 1.05 1030.7±5.70µs ? ?/sec 1.00 985.0±2.01µs ? ?/sec
physical_join_distinct 1.08 250.5±2.57µs ? ?/sec 1.00 233.0±6.26µs ? ?/sec
physical_many_self_joins 1.02 7.7±0.01ms ? ?/sec 1.00 7.6±0.02ms ? ?/sec
physical_plan_clickbench_all 1.01 129.6±0.52ms ? ?/sec 1.00 127.7±0.32ms ? ?/sec
physical_plan_clickbench_q1 1.02 1366.7±5.66µs ? ?/sec 1.00 1336.7±8.32µs ? ?/sec
physical_plan_clickbench_q10 1.02 2.0±0.01ms ? ?/sec 1.00 2.0±0.01ms ? ?/sec
physical_plan_clickbench_q11 1.01 2.2±0.01ms ? ?/sec 1.00 2.2±0.01ms ? ?/sec
physical_plan_clickbench_q12 1.01 2.3±0.00ms ? ?/sec 1.00 2.3±0.01ms ? ?/sec
physical_plan_clickbench_q13 1.01 2.1±0.01ms ? ?/sec 1.00 2.0±0.01ms ? ?/sec
physical_plan_clickbench_q14 1.03 2.3±0.01ms ? ?/sec 1.00 2.2±0.01ms ? ?/sec
physical_plan_clickbench_q15 1.03 2.2±0.01ms ? ?/sec 1.00 2.1±0.01ms ? ?/sec
physical_plan_clickbench_q16 1.03 1776.1±6.20µs ? ?/sec 1.00 1721.7±7.38µs ? ?/sec
physical_plan_clickbench_q17 1.03 1830.9±5.27µs ? ?/sec 1.00 1774.5±7.30µs ? ?/sec
physical_plan_clickbench_q18 1.03 1663.3±5.22µs ? ?/sec 1.00 1614.2±5.81µs ? ?/sec
physical_plan_clickbench_q19 1.01 2.0±0.01ms ? ?/sec 1.00 1998.0±6.26µs ? ?/sec
physical_plan_clickbench_q2 1.01 1782.6±4.65µs ? ?/sec 1.00 1771.0±6.02µs ? ?/sec
physical_plan_clickbench_q20 1.01 1516.4±5.55µs ? ?/sec 1.00 1508.2±7.32µs ? ?/sec
physical_plan_clickbench_q21 1.02 1779.6±4.88µs ? ?/sec 1.00 1748.3±4.77µs ? ?/sec
physical_plan_clickbench_q22 1.00 2.2±0.02ms ? ?/sec 1.00 2.2±0.01ms ? ?/sec
physical_plan_clickbench_q23 1.01 2.4±0.02ms ? ?/sec 1.00 2.4±0.01ms ? ?/sec
physical_plan_clickbench_q24 1.00 5.7±0.01ms ? ?/sec 1.00 5.7±0.03ms ? ?/sec
physical_plan_clickbench_q25 1.02 1939.0±6.35µs ? ?/sec 1.00 1895.3±6.02µs ? ?/sec
physical_plan_clickbench_q26 1.03 1759.0±5.63µs ? ?/sec 1.00 1715.2±5.96µs ? ?/sec
physical_plan_clickbench_q27 1.02 1955.7±5.42µs ? ?/sec 1.00 1920.5±4.87µs ? ?/sec
physical_plan_clickbench_q28 1.00 2.4±0.01ms ? ?/sec 1.00 2.4±0.01ms ? ?/sec
physical_plan_clickbench_q29 1.01 2.6±0.01ms ? ?/sec 1.00 2.6±0.01ms ? ?/sec
physical_plan_clickbench_q3 1.00 1638.0±6.04µs ? ?/sec 1.00 1633.3±5.95µs ? ?/sec
physical_plan_clickbench_q30 1.00 16.4±0.04ms ? ?/sec 1.01 16.5±0.08ms ? ?/sec
physical_plan_clickbench_q31 1.01 2.5±0.01ms ? ?/sec 1.00 2.5±0.01ms ? ?/sec
physical_plan_clickbench_q32 1.01 2.5±0.01ms ? ?/sec 1.00 2.4±0.01ms ? ?/sec
physical_plan_clickbench_q33 1.01 2.0±0.01ms ? ?/sec 1.00 1983.8±6.36µs ? ?/sec
physical_plan_clickbench_q34 1.01 1749.6±5.55µs ? ?/sec 1.00 1727.9±6.91µs ? ?/sec
physical_plan_clickbench_q35 1.03 1847.7±6.58µs ? ?/sec 1.00 1796.1±6.28µs ? ?/sec
physical_plan_clickbench_q36 1.03 2.2±0.01ms ? ?/sec 1.00 2.1±0.01ms ? ?/sec
physical_plan_clickbench_q37 1.02 2.6±0.01ms ? ?/sec 1.00 2.6±0.01ms ? ?/sec
physical_plan_clickbench_q38 1.02 2.6±0.01ms ? ?/sec 1.00 2.6±0.01ms ? ?/sec
physical_plan_clickbench_q39 1.02 2.7±0.01ms ? ?/sec 1.00 2.7±0.01ms ? ?/sec
physical_plan_clickbench_q4 1.01 1446.5±5.71µs ? ?/sec 1.00 1427.0±5.69µs ? ?/sec
physical_plan_clickbench_q40 1.01 3.5±0.01ms ? ?/sec 1.00 3.5±0.01ms ? ?/sec
physical_plan_clickbench_q41 1.01 3.0±0.01ms ? ?/sec 1.00 2.9±0.01ms ? ?/sec
physical_plan_clickbench_q42 1.00 3.1±0.01ms ? ?/sec 1.00 3.1±0.01ms ? ?/sec
physical_plan_clickbench_q43 1.01 3.3±0.01ms ? ?/sec 1.00 3.2±0.01ms ? ?/sec
physical_plan_clickbench_q44 1.02 1551.9±6.18µs ? ?/sec 1.00 1520.4±8.37µs ? ?/sec
physical_plan_clickbench_q45 1.02 1556.5±6.48µs ? ?/sec 1.00 1523.3±6.96µs ? ?/sec
physical_plan_clickbench_q46 1.02 1892.1±12.17µs ? ?/sec 1.00 1852.2±5.65µs ? ?/sec
physical_plan_clickbench_q47 1.00 2.6±0.01ms ? ?/sec 1.00 2.6±0.01ms ? ?/sec
physical_plan_clickbench_q48 1.00 2.9±0.01ms ? ?/sec 1.00 2.9±0.01ms ? ?/sec
physical_plan_clickbench_q49 1.01 2.9±0.01ms ? ?/sec 1.00 2.9±0.01ms ? ?/sec
physical_plan_clickbench_q5 1.01 1586.9±5.64µs ? ?/sec 1.00 1566.9±6.12µs ? ?/sec
physical_plan_clickbench_q50 1.02 2.9±0.00ms ? ?/sec 1.00 2.9±0.02ms ? ?/sec
physical_plan_clickbench_q51 1.02 2.0±0.01ms ? ?/sec 1.00 1976.5±7.43µs ? ?/sec
physical_plan_clickbench_q6 1.01 1590.9±6.10µs ? ?/sec 1.00 1577.8±6.24µs ? ?/sec
physical_plan_clickbench_q7 1.02 1619.2±5.10µs ? ?/sec 1.00 1585.8±6.64µs ? ?/sec
physical_plan_clickbench_q8 1.01 1929.1±6.56µs ? ?/sec 1.00 1916.3±12.66µs ? ?/sec
physical_plan_clickbench_q9 1.01 1895.9±5.93µs ? ?/sec 1.00 1876.3±6.55µs ? ?/sec
physical_plan_struct_join_agg_sort 1.00 1355.3±3.34µs ? ?/sec 1.01 1363.2±2.51µs ? ?/sec
physical_plan_tpcds_all 1.01 755.4±3.76ms ? ?/sec 1.00 750.7±4.15ms ? ?/sec
physical_plan_tpch_all 1.00 48.9±0.06ms ? ?/sec 1.00 48.8±0.08ms ? ?/sec
physical_plan_tpch_q1 1.00 1583.1±3.97µs ? ?/sec 1.00 1578.9±2.76µs ? ?/sec
physical_plan_tpch_q10 1.01 3.1±0.00ms ? ?/sec 1.00 3.0±0.00ms ? ?/sec
physical_plan_tpch_q11 1.01 2.6±0.00ms ? ?/sec 1.00 2.6±0.00ms ? ?/sec
physical_plan_tpch_q12 1.01 1326.6±2.56µs ? ?/sec 1.00 1309.6±3.03µs ? ?/sec
physical_plan_tpch_q13 1.02 999.7±2.38µs ? ?/sec 1.00 984.9±2.00µs ? ?/sec
physical_plan_tpch_q14 1.01 1450.1±3.03µs ? ?/sec 1.00 1438.0±2.72µs ? ?/sec
physical_plan_tpch_q16 1.03 1685.4±14.31µs ? ?/sec 1.00 1632.3±1.89µs ? ?/sec
physical_plan_tpch_q17 1.02 1823.5±3.99µs ? ?/sec 1.00 1789.3±2.77µs ? ?/sec
physical_plan_tpch_q18 1.01 1913.9±2.35µs ? ?/sec 1.00 1897.2±2.33µs ? ?/sec
physical_plan_tpch_q19 1.00 2.5±0.00ms ? ?/sec 1.00 2.5±0.00ms ? ?/sec
physical_plan_tpch_q2 1.01 4.4±0.01ms ? ?/sec 1.00 4.3±0.00ms ? ?/sec
physical_plan_tpch_q20 1.00 2.4±0.00ms ? ?/sec 1.00 2.4±0.00ms ? ?/sec
physical_plan_tpch_q21 1.00 3.2±0.00ms ? ?/sec 1.00 3.2±0.00ms ? ?/sec
physical_plan_tpch_q22 1.01 2.1±0.00ms ? ?/sec 1.00 2.0±0.00ms ? ?/sec
physical_plan_tpch_q3 1.02 2.1±0.00ms ? ?/sec 1.00 2.0±0.00ms ? ?/sec
physical_plan_tpch_q4 1.02 1181.7±2.28µs ? ?/sec 1.00 1160.0±2.19µs ? ?/sec
physical_plan_tpch_q5 1.00 2.6±0.00ms ? ?/sec 1.00 2.6±0.00ms ? ?/sec
physical_plan_tpch_q6 1.01 661.2±2.16µs ? ?/sec 1.00 657.4±2.68µs ? ?/sec
physical_plan_tpch_q7 1.00 3.2±0.00ms ? ?/sec 1.01 3.2±0.00ms ? ?/sec
physical_plan_tpch_q8 1.00 4.2±0.01ms ? ?/sec 1.00 4.2±0.01ms ? ?/sec
physical_plan_tpch_q9 1.00 3.0±0.00ms ? ?/sec 1.00 3.0±0.00ms ? ?/sec
physical_select_aggregates_from_200 1.00 14.6±0.04ms ? ?/sec 1.00 14.6±0.03ms ? ?/sec
physical_select_all_from_1000 1.04 18.3±0.12ms ? ?/sec 1.00 17.5±0.04ms ? ?/sec
physical_select_one_from_700 1.12 793.5±5.80µs ? ?/sec 1.00 710.9±1.76µs ? ?/sec
physical_sorted_union_order_by_10_int64 1.00 4.8±0.01ms ? ?/sec 1.00 4.8±0.01ms ? ?/sec
physical_sorted_union_order_by_10_uint64 1.00 11.6±0.02ms ? ?/sec 1.00 11.7±0.01ms ? ?/sec
physical_sorted_union_order_by_50_int64 1.00 115.0±0.34ms ? ?/sec 1.00 115.1±0.30ms ? ?/sec
physical_sorted_union_order_by_50_uint64 1.00 608.1±3.04ms ? ?/sec 1.00 609.2±3.07ms ? ?/sec
physical_theta_join_consider_sort 1.05 1067.8±6.14µs ? ?/sec 1.00 1019.0±2.35µs ? ?/sec
physical_unnest_to_join 1.06 1236.6±2.66µs ? ?/sec 1.00 1168.1±2.27µs ? ?/sec
physical_window_function_partition_by_12_on_values 1.02 758.9±4.81µs ? ?/sec 1.00 745.5±1.32µs ? ?/sec
physical_window_function_partition_by_30_on_values 1.00 1497.1±2.54µs ? ?/sec 1.00 1502.0±2.18µs ? ?/sec
physical_window_function_partition_by_4_on_values 1.01 453.7±1.14µs ? ?/sec 1.00 449.0±1.10µs ? ?/sec
physical_window_function_partition_by_7_on_values 1.02 567.0±1.19µs ? ?/sec 1.00 558.3±1.37µs ? ?/sec
physical_window_function_partition_by_8_on_values 1.02 608.5±3.11µs ? ?/sec 1.00 597.6±1.08µs ? ?/sec
with_param_values_many_columns 1.00 462.5±1.83µs ? ?/sec 1.00 460.8±4.09µs ? ?/sec
```
</p>
</details>
<details><summary>Resource Usage</summary>
**base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 1240.4s |
| Peak memory | 18.2 GiB |
| Avg memory | 18.1 GiB |
| CPU user | 1484.0s |
| CPU sys | 1.7s |
| Peak spill | 0 B |
**branch**
| Metric | Value |
|--------|-------|
| Wall time | 1246.5s |
| Peak memory | 18.2 GiB |
| Avg memory | 18.1 GiB |
| CPU user | 1491.3s |
| CPU sys | 1.1s |
| Peak spill | 0 B |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "neilconway (via GitHub)" <gi...@apache.org>.
neilconway commented on code in PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#discussion_r3106753103
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1338,11 +1338,44 @@ impl SchemaExt for Schema {
}
}
+/// Build a fully-qualified field name string. This is equivalent to
+/// `format!("{q}.{name}")` when `qualifier` is `Some`, or just `name` when
+/// `None`. We avoid going through the `fmt` machinery for performance reasons.
pub fn qualified_name(qualifier: Option<&TableReference>, name: &str) -> String {
- match qualifier {
- Some(q) => format!("{q}.{name}"),
- None => name.to_string(),
- }
+ let qualifier = match qualifier {
+ None => return name.to_string(),
+ Some(q) => q,
+ };
+ let (a, b, c) = match qualifier {
Review Comment:
Thanks; I went with `first`, `second`, `third`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "neilconway (via GitHub)" <gi...@apache.org>.
neilconway commented on code in PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#discussion_r3106950589
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1338,11 +1338,44 @@ impl SchemaExt for Schema {
}
}
+/// Build a fully-qualified field name string. This is equivalent to
+/// `format!("{q}.{name}")` when `qualifier` is `Some`, or just `name` when
+/// `None`. We avoid going through the `fmt` machinery for performance reasons.
pub fn qualified_name(qualifier: Option<&TableReference>, name: &str) -> String {
Review Comment:
Yes, definitely -- one spot that came up as a candidate for memoizing was `DFSchema::field_names`. I wanted to start with this PR because it is a win regardless, but I'll take a look at that in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#issuecomment-4274472561
🤖 Criterion benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21722#issuecomment-4274464954)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c4274464954-1483-wfmlq 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing neilc/perf-planner-qualified-name (ec144c1313535429a0d18a161685c5115865d6d4) to b75df6f (merge-base) [diff](https://github.com/apache/datafusion/compare/b75df6f01eed95fbecae2dd4ab4b55ffc6b852a6..ec144c1313535429a0d18a161685c5115865d6d4)
BENCH_NAME=sql_planner
BENCH_COMMAND=cargo bench --features=parquet --bench sql_planner
BENCH_FILTER=
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#issuecomment-4274554064
🤖 Criterion benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21722#issuecomment-4274464954)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
group main neilc_perf-planner-qualified-name
----- ---- ---------------------------------
logical_aggregate_with_join 1.06 436.9±1.72µs ? ?/sec 1.00 412.8±1.28µs ? ?/sec
logical_plan_struct_join_agg_sort 1.02 167.2±0.61µs ? ?/sec 1.00 164.1±0.68µs ? ?/sec
logical_select_all_from_1000 1.01 8.4±0.04ms ? ?/sec 1.00 8.3±0.02ms ? ?/sec
logical_select_one_from_700 1.17 321.3±1.51µs ? ?/sec 1.00 273.9±1.49µs ? ?/sec
logical_trivial_join_high_numbered_columns 1.06 266.9±0.97µs ? ?/sec 1.00 251.6±1.19µs ? ?/sec
logical_trivial_join_low_numbered_columns 1.06 254.6±1.00µs ? ?/sec 1.00 239.1±1.14µs ? ?/sec
physical_intersection 1.08 602.3±1.75µs ? ?/sec 1.00 557.4±2.13µs ? ?/sec
physical_join_consider_sort 1.02 1030.8±2.77µs ? ?/sec 1.00 1009.0±3.29µs ? ?/sec
physical_join_distinct 1.07 249.1±0.98µs ? ?/sec 1.00 233.7±1.20µs ? ?/sec
physical_many_self_joins 1.00 7.7±0.01ms ? ?/sec 1.00 7.7±0.03ms ? ?/sec
physical_plan_clickbench_all 1.02 129.2±0.39ms ? ?/sec 1.00 127.1±0.52ms ? ?/sec
physical_plan_clickbench_q1 1.00 1377.0±12.46µs ? ?/sec 1.00 1378.6±33.39µs ? ?/sec
physical_plan_clickbench_q10 1.00 2.0±0.01ms ? ?/sec 1.00 2.0±0.01ms ? ?/sec
physical_plan_clickbench_q11 1.01 2.2±0.01ms ? ?/sec 1.00 2.2±0.01ms ? ?/sec
physical_plan_clickbench_q12 1.02 2.3±0.02ms ? ?/sec 1.00 2.3±0.01ms ? ?/sec
physical_plan_clickbench_q13 1.00 2.1±0.01ms ? ?/sec 1.00 2.1±0.01ms ? ?/sec
physical_plan_clickbench_q14 1.01 2.2±0.01ms ? ?/sec 1.00 2.2±0.01ms ? ?/sec
physical_plan_clickbench_q15 1.02 2.1±0.01ms ? ?/sec 1.00 2.1±0.00ms ? ?/sec
physical_plan_clickbench_q16 1.01 1740.4±7.80µs ? ?/sec 1.00 1715.4±7.34µs ? ?/sec
physical_plan_clickbench_q17 1.03 1838.3±9.41µs ? ?/sec 1.00 1791.5±5.60µs ? ?/sec
physical_plan_clickbench_q18 1.00 1628.1±6.18µs ? ?/sec 1.00 1624.9±5.07µs ? ?/sec
physical_plan_clickbench_q19 1.02 2.1±0.01ms ? ?/sec 1.00 2.0±0.01ms ? ?/sec
physical_plan_clickbench_q2 1.00 1776.8±7.45µs ? ?/sec 1.03 1838.9±52.75µs ? ?/sec
physical_plan_clickbench_q20 1.04 1576.8±18.47µs ? ?/sec 1.00 1515.7±7.31µs ? ?/sec
physical_plan_clickbench_q21 1.04 1819.4±5.34µs ? ?/sec 1.00 1751.0±15.86µs ? ?/sec
physical_plan_clickbench_q22 1.06 2.3±0.07ms ? ?/sec 1.00 2.2±0.00ms ? ?/sec
physical_plan_clickbench_q23 1.07 2.6±0.18ms ? ?/sec 1.00 2.4±0.01ms ? ?/sec
physical_plan_clickbench_q24 1.03 5.8±0.10ms ? ?/sec 1.00 5.7±0.02ms ? ?/sec
physical_plan_clickbench_q25 1.02 1930.2±11.08µs ? ?/sec 1.00 1900.4±14.97µs ? ?/sec
physical_plan_clickbench_q26 1.00 1746.8±7.97µs ? ?/sec 1.00 1738.8±11.10µs ? ?/sec
physical_plan_clickbench_q27 1.02 1946.8±7.16µs ? ?/sec 1.00 1908.4±14.63µs ? ?/sec
physical_plan_clickbench_q28 1.05 2.5±0.01ms ? ?/sec 1.00 2.4±0.01ms ? ?/sec
physical_plan_clickbench_q29 1.05 2.7±0.01ms ? ?/sec 1.00 2.6±0.01ms ? ?/sec
physical_plan_clickbench_q3 1.01 1632.4±6.75µs ? ?/sec 1.00 1620.5±14.72µs ? ?/sec
physical_plan_clickbench_q30 1.01 16.5±0.07ms ? ?/sec 1.00 16.3±0.04ms ? ?/sec
physical_plan_clickbench_q31 1.04 2.6±0.01ms ? ?/sec 1.00 2.5±0.01ms ? ?/sec
physical_plan_clickbench_q32 1.04 2.6±0.01ms ? ?/sec 1.00 2.4±0.01ms ? ?/sec
physical_plan_clickbench_q33 1.03 2.0±0.02ms ? ?/sec 1.00 1981.6±8.47µs ? ?/sec
physical_plan_clickbench_q34 1.03 1768.2±7.62µs ? ?/sec 1.00 1722.4±6.18µs ? ?/sec
physical_plan_clickbench_q35 1.03 1830.3±7.07µs ? ?/sec 1.00 1785.5±6.92µs ? ?/sec
physical_plan_clickbench_q36 1.02 2.2±0.01ms ? ?/sec 1.00 2.1±0.01ms ? ?/sec
physical_plan_clickbench_q37 1.02 2.6±0.01ms ? ?/sec 1.00 2.6±0.01ms ? ?/sec
physical_plan_clickbench_q38 1.02 2.6±0.01ms ? ?/sec 1.00 2.6±0.00ms ? ?/sec
physical_plan_clickbench_q39 1.02 2.7±0.01ms ? ?/sec 1.00 2.7±0.00ms ? ?/sec
physical_plan_clickbench_q4 1.01 1433.9±6.17µs ? ?/sec 1.00 1423.3±7.39µs ? ?/sec
physical_plan_clickbench_q40 1.02 3.5±0.01ms ? ?/sec 1.00 3.4±0.01ms ? ?/sec
physical_plan_clickbench_q41 1.01 3.0±0.01ms ? ?/sec 1.00 2.9±0.00ms ? ?/sec
physical_plan_clickbench_q42 1.01 3.2±0.01ms ? ?/sec 1.00 3.1±0.01ms ? ?/sec
physical_plan_clickbench_q43 1.01 3.3±0.01ms ? ?/sec 1.00 3.2±0.01ms ? ?/sec
physical_plan_clickbench_q44 1.03 1542.3±6.42µs ? ?/sec 1.00 1499.9±6.66µs ? ?/sec
physical_plan_clickbench_q45 1.03 1549.6±6.63µs ? ?/sec 1.00 1500.0±5.78µs ? ?/sec
physical_plan_clickbench_q46 1.02 1871.5±7.97µs ? ?/sec 1.00 1841.2±6.98µs ? ?/sec
physical_plan_clickbench_q47 1.02 2.7±0.01ms ? ?/sec 1.00 2.6±0.02ms ? ?/sec
physical_plan_clickbench_q48 1.04 2.9±0.01ms ? ?/sec 1.00 2.8±0.01ms ? ?/sec
physical_plan_clickbench_q49 1.01 3.0±0.02ms ? ?/sec 1.00 3.0±0.03ms ? ?/sec
physical_plan_clickbench_q5 1.00 1573.7±7.15µs ? ?/sec 1.00 1571.9±7.38µs ? ?/sec
physical_plan_clickbench_q50 1.03 2.9±0.01ms ? ?/sec 1.00 2.9±0.01ms ? ?/sec
physical_plan_clickbench_q51 1.03 1999.0±7.11µs ? ?/sec 1.00 1946.9±10.41µs ? ?/sec
physical_plan_clickbench_q6 1.00 1579.5±7.34µs ? ?/sec 1.00 1575.9±7.02µs ? ?/sec
physical_plan_clickbench_q7 1.01 1610.8±5.51µs ? ?/sec 1.00 1602.0±6.01µs ? ?/sec
physical_plan_clickbench_q8 1.01 1940.8±29.36µs ? ?/sec 1.00 1921.4±7.61µs ? ?/sec
physical_plan_clickbench_q9 1.00 1897.2±6.56µs ? ?/sec 1.00 1897.9±7.08µs ? ?/sec
physical_plan_struct_join_agg_sort 1.01 1371.4±2.69µs ? ?/sec 1.00 1354.7±2.88µs ? ?/sec
physical_plan_tpcds_all 1.00 760.3±5.19ms ? ?/sec 1.00 757.4±19.42ms ? ?/sec
physical_plan_tpch_all 1.02 49.6±0.47ms ? ?/sec 1.00 48.6±0.27ms ? ?/sec
physical_plan_tpch_q1 1.03 1612.4±4.06µs ? ?/sec 1.00 1570.4±2.42µs ? ?/sec
physical_plan_tpch_q10 1.01 3.1±0.00ms ? ?/sec 1.00 3.1±0.00ms ? ?/sec
physical_plan_tpch_q11 1.01 2.6±0.00ms ? ?/sec 1.00 2.6±0.00ms ? ?/sec
physical_plan_tpch_q12 1.00 1328.5±2.79µs ? ?/sec 1.00 1329.7±2.85µs ? ?/sec
physical_plan_tpch_q13 1.00 1000.7±2.56µs ? ?/sec 1.00 1004.2±2.36µs ? ?/sec
physical_plan_tpch_q14 1.00 1458.8±3.47µs ? ?/sec 1.00 1462.2±3.44µs ? ?/sec
physical_plan_tpch_q16 1.02 1670.0±1.89µs ? ?/sec 1.00 1633.1±6.90µs ? ?/sec
physical_plan_tpch_q17 1.04 1860.8±3.60µs ? ?/sec 1.00 1786.8±3.19µs ? ?/sec
physical_plan_tpch_q18 1.05 1956.8±2.81µs ? ?/sec 1.00 1870.6±2.96µs ? ?/sec
physical_plan_tpch_q19 1.02 2.5±0.00ms ? ?/sec 1.00 2.5±0.01ms ? ?/sec
physical_plan_tpch_q2 1.02 4.4±0.00ms ? ?/sec 1.00 4.3±0.00ms ? ?/sec
physical_plan_tpch_q20 1.03 2.4±0.00ms ? ?/sec 1.00 2.4±0.00ms ? ?/sec
physical_plan_tpch_q21 1.01 3.2±0.00ms ? ?/sec 1.00 3.1±0.00ms ? ?/sec
physical_plan_tpch_q22 1.02 2.1±0.00ms ? ?/sec 1.00 2.0±0.00ms ? ?/sec
physical_plan_tpch_q3 1.02 2.1±0.00ms ? ?/sec 1.00 2.0±0.00ms ? ?/sec
physical_plan_tpch_q4 1.01 1168.1±2.31µs ? ?/sec 1.00 1157.4±3.16µs ? ?/sec
physical_plan_tpch_q5 1.00 2.7±0.00ms ? ?/sec 1.00 2.7±0.00ms ? ?/sec
physical_plan_tpch_q6 1.01 677.3±3.84µs ? ?/sec 1.00 673.3±1.79µs ? ?/sec
physical_plan_tpch_q7 1.00 3.2±0.00ms ? ?/sec 1.00 3.3±0.00ms ? ?/sec
physical_plan_tpch_q8 1.01 4.3±0.01ms ? ?/sec 1.00 4.2±0.00ms ? ?/sec
physical_plan_tpch_q9 1.01 3.0±0.00ms ? ?/sec 1.00 3.0±0.00ms ? ?/sec
physical_select_aggregates_from_200 1.00 14.5±0.03ms ? ?/sec 1.00 14.6±0.02ms ? ?/sec
physical_select_all_from_1000 1.01 18.2±0.09ms ? ?/sec 1.00 18.0±0.05ms ? ?/sec
physical_select_one_from_700 1.11 794.4±1.60µs ? ?/sec 1.00 718.8±1.70µs ? ?/sec
physical_sorted_union_order_by_10_int64 1.01 4.8±0.01ms ? ?/sec 1.00 4.8±0.01ms ? ?/sec
physical_sorted_union_order_by_10_uint64 1.02 11.8±0.07ms ? ?/sec 1.00 11.7±0.06ms ? ?/sec
physical_sorted_union_order_by_50_int64 1.02 116.6±0.77ms ? ?/sec 1.00 114.3±0.37ms ? ?/sec
physical_sorted_union_order_by_50_uint64 1.02 610.9±3.80ms ? ?/sec 1.00 597.2±1.36ms ? ?/sec
physical_theta_join_consider_sort 1.05 1077.1±5.98µs ? ?/sec 1.00 1029.3±2.33µs ? ?/sec
physical_unnest_to_join 1.04 1234.3±1.84µs ? ?/sec 1.00 1183.3±3.53µs ? ?/sec
physical_window_function_partition_by_12_on_values 1.00 748.7±1.22µs ? ?/sec 1.01 753.1±1.59µs ? ?/sec
physical_window_function_partition_by_30_on_values 1.00 1510.5±3.05µs ? ?/sec 1.00 1509.1±2.72µs ? ?/sec
physical_window_function_partition_by_4_on_values 1.02 451.5±1.01µs ? ?/sec 1.00 440.7±1.08µs ? ?/sec
physical_window_function_partition_by_7_on_values 1.00 560.6±1.95µs ? ?/sec 1.00 562.7±1.16µs ? ?/sec
physical_window_function_partition_by_8_on_values 1.00 602.0±1.39µs ? ?/sec 1.00 604.5±1.16µs ? ?/sec
with_param_values_many_columns 1.00 463.1±2.16µs ? ?/sec 1.01 465.6±2.44µs ? ?/sec
```
</p>
</details>
<details><summary>Resource Usage</summary>
**base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 1242.6s |
| Peak memory | 18.5 GiB |
| Avg memory | 18.5 GiB |
| CPU user | 1486.0s |
| CPU sys | 1.7s |
| Peak spill | 0 B |
**branch**
| Metric | Value |
|--------|-------|
| Wall time | 1239.3s |
| Peak memory | 18.5 GiB |
| Avg memory | 18.5 GiB |
| CPU user | 1483.9s |
| CPU sys | 1.1s |
| Peak spill | 0 B |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on code in PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#discussion_r3106662315
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1338,11 +1338,44 @@ impl SchemaExt for Schema {
}
}
+/// Build a fully-qualified field name string. This is equivalent to
+/// `format!("{q}.{name}")` when `qualifier` is `Some`, or just `name` when
+/// `None`. We avoid going through the `fmt` machinery for performance reasons.
pub fn qualified_name(qualifier: Option<&TableReference>, name: &str) -> String {
- match qualifier {
- Some(q) => format!("{q}.{name}"),
- None => name.to_string(),
- }
+ let qualifier = match qualifier {
+ None => return name.to_string(),
+ Some(q) => q,
+ };
+ let (a, b, c) = match qualifier {
+ TableReference::Bare { table } => (table.as_ref(), None, None),
+ TableReference::Partial { schema, table } => {
+ (schema.as_ref(), Some(table.as_ref()), None)
+ }
+ TableReference::Full {
+ catalog,
+ schema,
+ table,
+ } => (
+ catalog.as_ref(),
+ Some(schema.as_ref()),
+ Some(table.as_ref()),
+ ),
+ };
+
+ let extra = b.unwrap_or("").len() + c.unwrap_or("").len();
Review Comment:
`b.map(|x|x.len()).unwrap_or(0) + c.map(|x|x.len()).unwrap_or(0)`
Would avoid the strings here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "neilconway (via GitHub)" <gi...@apache.org>.
neilconway commented on code in PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#discussion_r3106752081
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1338,11 +1338,44 @@ impl SchemaExt for Schema {
}
}
+/// Build a fully-qualified field name string. This is equivalent to
+/// `format!("{q}.{name}")` when `qualifier` is `Some`, or just `name` when
+/// `None`. We avoid going through the `fmt` machinery for performance reasons.
pub fn qualified_name(qualifier: Option<&TableReference>, name: &str) -> String {
- match qualifier {
- Some(q) => format!("{q}.{name}"),
- None => name.to_string(),
- }
+ let qualifier = match qualifier {
+ None => return name.to_string(),
+ Some(q) => q,
+ };
+ let (a, b, c) = match qualifier {
+ TableReference::Bare { table } => (table.as_ref(), None, None),
+ TableReference::Partial { schema, table } => {
+ (schema.as_ref(), Some(table.as_ref()), None)
+ }
+ TableReference::Full {
+ catalog,
+ schema,
+ table,
+ } => (
+ catalog.as_ref(),
+ Some(schema.as_ref()),
+ Some(table.as_ref()),
+ ),
+ };
+
+ let extra = b.unwrap_or("").len() + c.unwrap_or("").len();
Review Comment:
Thanks, good idea! `map_or(0, x.len())` is even better I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "neilconway (via GitHub)" <gi...@apache.org>.
neilconway commented on PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#issuecomment-4274464954
run benchmark sql_planner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#discussion_r3106945634
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1338,11 +1338,44 @@ impl SchemaExt for Schema {
}
}
+/// Build a fully-qualified field name string. This is equivalent to
+/// `format!("{q}.{name}")` when `qualifier` is `Some`, or just `name` when
+/// `None`. We avoid going through the `fmt` machinery for performance reasons.
pub fn qualified_name(qualifier: Option<&TableReference>, name: &str) -> String {
Review Comment:
As I recall, this code gets repeatedly called to compute the schema (and the schema has the column names) for many things.
I think a more impactful PR (as a follow on) would be to avoid the need to continually recompute this qualified name somehow -- but it probably requires storing the state somehow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21722:
URL: https://github.com/apache/datafusion/pull/21722#issuecomment-4276082242
🤖 Criterion benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21722#issuecomment-4276063029)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c4276063029-1554-86f4d 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing neilc/perf-planner-qualified-name (33cfa9d08ea88b5430999820ad83f395bb2b90e0) to b75df6f (merge-base) [diff](https://github.com/apache/datafusion/compare/b75df6f01eed95fbecae2dd4ab4b55ffc6b852a6..33cfa9d08ea88b5430999820ad83f395bb2b90e0)
BENCH_NAME=sql_planner
BENCH_COMMAND=cargo bench --features=parquet --bench sql_planner
BENCH_FILTER=
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Optimize `DFSchema::qualified_name` [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #21722:
URL: https://github.com/apache/datafusion/pull/21722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org