You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2025/04/02 06:35:04 UTC
[PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
amoghrajesh opened a new pull request, #48657:
URL: https://github.com/apache/airflow/pull/48657
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
#48579 and #48528 removed Sequential and Debug Executors. We should add significant newsfrags for these as it is a behaviour change for end users.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #48657:
URL: https://github.com/apache/airflow/pull/48657#issuecomment-2771479037
Nah I do not think so from looking at the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #48657:
URL: https://github.com/apache/airflow/pull/48657#issuecomment-2771495467
Wondering that too. Is it possible to have a rule to override either of those to LocalExec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #48657:
URL: https://github.com/apache/airflow/pull/48657#issuecomment-2774697750
@eladkal that change has been made. I am getting the debugexecutor doc refs removed too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #48657:
URL: https://github.com/apache/airflow/pull/48657#issuecomment-2771561484
> Wondering that too. Is it possible to have a rule to override either of those to LocalExec?
We could add it to the `airflow config lint` section. Then, we'll figure out how we do it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #48657:
URL: https://github.com/apache/airflow/pull/48657#issuecomment-2771493212
> > > Nah I do not think so from looking at the code
> >
> >
> > How do people set it to Sequential / Debug in the past?
>
> It was using either the config or env variable: https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/executor/index.html
Then I think we might still need a config rule then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #48657:
URL: https://github.com/apache/airflow/pull/48657#issuecomment-2771481822
> Nah I do not think so from looking at the code
How do people set it to Sequential / Debug in。the past?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #48657:
URL: https://github.com/apache/airflow/pull/48657#discussion_r2026304318
##########
airflow-core/newsfragments/48579.significant.rst:
##########
@@ -0,0 +1,22 @@
+``DebugExecutor`` has been removed from the in-tree executors.
+
+This executor was primarily used for local testing but is now redundant, as ``LocalExecutor``
+supports SQLite with WAL mode and provides better performance with parallel execution.
+Users should switch to ``LocalExecutor`` or ``CeleryExecutor`` as alternatives.
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [x] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [ ] Code interface changes
+
+* Migration rules needed
+
+ * ``airflow config lint``
+
+ * [ ] Convert all ``DebugExecutor`` to ``LocalExecutor`` in ``[core] executor``
Review Comment:
Good call. Let me update this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #48657:
URL: https://github.com/apache/airflow/pull/48657#discussion_r2028288147
##########
airflow-core/newsfragments/48579.significant.rst:
##########
@@ -0,0 +1,22 @@
+``DebugExecutor`` has been removed from the in-tree executors.
+
+This executor was primarily used for local testing but is now redundant, as ``LocalExecutor``
+supports SQLite with WAL mode and provides better performance with parallel execution.
+Users should switch to ``LocalExecutor`` or ``CeleryExecutor`` as alternatives.
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
Review Comment:
```suggestion
* [x] Config changes
```
##########
airflow-core/newsfragments/48528.significant.rst:
##########
@@ -0,0 +1,22 @@
+``SequentialExecutor`` has been removed from the in-tree executors.
+
+This executor was primarily used for local testing but is now redundant, as ``LocalExecutor``
+supports SQLite with WAL mode and provides better performance with parallel execution.
+Users should switch to ``LocalExecutor`` or ``CeleryExecutor`` as alternatives.
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
Review Comment:
```suggestion
* [x] Config changes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #48657:
URL: https://github.com/apache/airflow/pull/48657#issuecomment-2774614697
@Lee-W let me do that yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #48657:
URL: https://github.com/apache/airflow/pull/48657#issuecomment-2771481589
@Lee-W there is a possibility of doing something of that sort in "core \ executor" config but we shield it now and do not allow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #48657:
URL: https://github.com/apache/airflow/pull/48657#issuecomment-2771482691
cc @eladkal maybe you are the right person for this, can these executors be set anywhere in the code / config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #48657:
URL: https://github.com/apache/airflow/pull/48657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #48657:
URL: https://github.com/apache/airflow/pull/48657#issuecomment-2771485133
> > Nah I do not think so from looking at the code
>
> How do people set it to Sequential / Debug in the past?
It was using either the config or env variable: https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/executor/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding newsfragments for removed executors -- Sequential & Debug [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #48657:
URL: https://github.com/apache/airflow/pull/48657#discussion_r2026301200
##########
airflow-core/newsfragments/48579.significant.rst:
##########
@@ -0,0 +1,22 @@
+``DebugExecutor`` has been removed from the in-tree executors.
+
+This executor was primarily used for local testing but is now redundant, as ``LocalExecutor``
+supports SQLite with WAL mode and provides better performance with parallel execution.
+Users should switch to ``LocalExecutor`` or ``CeleryExecutor`` as alternatives.
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [x] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [ ] Code interface changes
+
+* Migration rules needed
+
+ * ``airflow config lint``
+
+ * [ ] Convert all ``DebugExecutor`` to ``LocalExecutor`` in ``[core] executor``
Review Comment:
Is this right? DebugExecutor usage should be converted to `dag.test()`
Its actually been deprecated since
https://github.com/apache/airflow/pull/26400/files
https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/debug.html#comparison-with-debugexecutor
By the way, we need to remove refrences to DebugExecutor in our docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org