You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Daniel Dai <da...@gmail.com> on 2011/04/02 03:22:46 UTC
Review Request: New logical plan: Should not push up filter in front of
Bincond
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/544/
-----------------------------------------------------------
Review request for pig and thejas.
Summary
-------
The following script produce wrong result:
data = LOAD 'data.txt' using PigStorage() as (referrer:chararray, canonical_url:chararray, ip:chararray);
best_url = FOREACH data GENERATE ((canonical_url != '' and canonical_url is not null) ? canonical_url : referrer) AS url, ip;
filtered = FILTER best_url BY url == 'badsite.com';
dump filtered;
data.txt:
badsite.com 127.0.0.1
goodsite.com/1?foo=true goodsite.com 127.0.0.1
Expected:
(badsite.com,127.0.0.1)
We get nothing.
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java 1085215
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterAboveForeach.java 1085215
Diff: https://reviews.apache.org/r/544/diff
Testing
-------
test-patch:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
Unit test:
all pass
End-to-end test:
all pass
Thanks,
Daniel
Re: Review Request: New logical plan: Should not push up filter in front of
Bincond
Posted by th...@yahoo.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/544/#review382
-----------------------------------------------------------
Ship it!
+1
- thejas
On 2011-04-04 18:10:55, Daniel Dai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/544/
> -----------------------------------------------------------
>
> (Updated 2011-04-04 18:10:55)
>
>
> Review request for pig and thejas.
>
>
> Summary
> -------
>
> The following script produce wrong result:
>
> data = LOAD 'data.txt' using PigStorage() as (referrer:chararray, canonical_url:chararray, ip:chararray);
> best_url = FOREACH data GENERATE ((canonical_url != '' and canonical_url is not null) ? canonical_url : referrer) AS url, ip;
> filtered = FILTER best_url BY url == 'badsite.com';
> dump filtered;
>
> data.txt:
> badsite.com 127.0.0.1
> goodsite.com/1?foo=true goodsite.com 127.0.0.1
>
> Expected:
> (badsite.com,127.0.0.1)
>
> We get nothing.
>
>
> This addresses bug PIG-1935.
> https://issues.apache.org/jira/browse/PIG-1935
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java 1085215
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterAboveForeach.java 1085215
>
> Diff: https://reviews.apache.org/r/544/diff
>
>
> Testing
> -------
>
> test-patch:
> [exec] +1 overall.
> [exec]
> [exec] +1 @author. The patch does not contain any @author tags.
> [exec]
> [exec] +1 tests included. The patch appears to include 3 new or modified tests.
> [exec]
> [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
> [exec]
> [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> [exec]
> [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
> [exec]
> [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
>
> Unit test:
> all pass
>
> End-to-end test:
> all pass
>
>
> Thanks,
>
> Daniel
>
>
Re: Review Request: New logical plan: Should not push up filter in front of
Bincond
Posted by Daniel Dai <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/544/
-----------------------------------------------------------
(Updated 2011-04-04 18:10:55.974552)
Review request for pig and thejas.
Summary
-------
The following script produce wrong result:
data = LOAD 'data.txt' using PigStorage() as (referrer:chararray, canonical_url:chararray, ip:chararray);
best_url = FOREACH data GENERATE ((canonical_url != '' and canonical_url is not null) ? canonical_url : referrer) AS url, ip;
filtered = FILTER best_url BY url == 'badsite.com';
dump filtered;
data.txt:
badsite.com 127.0.0.1
goodsite.com/1?foo=true goodsite.com 127.0.0.1
Expected:
(badsite.com,127.0.0.1)
We get nothing.
This addresses bug PIG-1935.
https://issues.apache.org/jira/browse/PIG-1935
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java 1085215
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterAboveForeach.java 1085215
Diff: https://reviews.apache.org/r/544/diff
Testing
-------
test-patch:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
Unit test:
all pass
End-to-end test:
all pass
Thanks,
Daniel
Re: Review Request: New logical plan: Should not push up filter in front of
Bincond
Posted by Daniel Dai <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/544/
-----------------------------------------------------------
(Updated 2011-04-04 03:56:53.825293)
Review request for pig and thejas.
Summary
-------
The following script produce wrong result:
data = LOAD 'data.txt' using PigStorage() as (referrer:chararray, canonical_url:chararray, ip:chararray);
best_url = FOREACH data GENERATE ((canonical_url != '' and canonical_url is not null) ? canonical_url : referrer) AS url, ip;
filtered = FILTER best_url BY url == 'badsite.com';
dump filtered;
data.txt:
badsite.com 127.0.0.1
goodsite.com/1?foo=true goodsite.com 127.0.0.1
Expected:
(badsite.com,127.0.0.1)
We get nothing.
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java 1085215
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterAboveForeach.java 1085215
Diff: https://reviews.apache.org/r/544/diff
Testing
-------
test-patch:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
Unit test:
all pass
End-to-end test:
all pass
Thanks,
Daniel
Re: Review Request: New logical plan: Should not push up filter in
front of Bincond
Posted by Daniel Dai <ji...@yahoo-inc.com>.
Sorry forget to mention this patch is for 0.8. For 0.9, the patch is
slightly different (but essentially the same).
Daniel
On 04/02/2011 04:35 PM, Dmitriy Ryaboy wrote:
> Daniel, I am getting an error when trying to view the diff:
>
> The patch to '
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java'
> didn't apply cleanly. The temporary files have been left in
> '/tmp/reviewboard.IBoaWc' for debugging purposes. `patch` returned: patching
> file /tmp/reviewboard.IBoaWc/tmpWoRpsq Hunk #1 FAILED at 98. 1 out of 1 hunk
> FAILED -- saving rejects to file /tmp/reviewboard.IBoaWc/tmpWoRpsq-new.rej
>
>
> D
>
> On Fri, Apr 1, 2011 at 6:22 PM, Daniel Dai<da...@gmail.com> wrote:
>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/544/
>> -----------------------------------------------------------
>>
>> Review request for pig and thejas.
>>
>>
>> Summary
>> -------
>>
>> The following script produce wrong result:
>>
>> data = LOAD 'data.txt' using PigStorage() as (referrer:chararray,
>> canonical_url:chararray, ip:chararray);
>> best_url = FOREACH data GENERATE ((canonical_url != '' and canonical_url is
>> not null) ? canonical_url : referrer) AS url, ip;
>> filtered = FILTER best_url BY url == 'badsite.com';
>> dump filtered;
>>
>> data.txt:
>> badsite.com 127.0.0.1
>> goodsite.com/1?foo=true goodsite.com 127.0.0.1
>>
>> Expected:
>> (badsite.com,127.0.0.1)
>>
>> We get nothing.
>>
>>
>> Diffs
>> -----
>>
>>
>> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java1085215
>>
>> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterAboveForeach.java1085215
>>
>> Diff: https://reviews.apache.org/r/544/diff
>>
>>
>> Testing
>> -------
>>
>> test-patch:
>> [exec] +1 overall.
>> [exec]
>> [exec] +1 @author. The patch does not contain any @author tags.
>> [exec]
>> [exec] +1 tests included. The patch appears to include 3 new or
>> modified tests.
>> [exec]
>> [exec] +1 javadoc. The javadoc tool did not generate any warning
>> messages.
>> [exec]
>> [exec] +1 javac. The applied patch does not increase the total
>> number of javac compiler warnings.
>> [exec]
>> [exec] +1 findbugs. The patch does not introduce any new Findbugs
>> warnings.
>> [exec]
>> [exec] +1 release audit. The applied patch does not increase the
>> total number of release audit warnings.
>>
>> Unit test:
>> all pass
>>
>> End-to-end test:
>> all pass
>>
>>
>> Thanks,
>>
>> Daniel
>>
>>
Re: Review Request: New logical plan: Should not push up filter in
front of Bincond
Posted by Dmitriy Ryaboy <dv...@gmail.com>.
Daniel, I am getting an error when trying to view the diff:
The patch to '
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java'
didn't apply cleanly. The temporary files have been left in
'/tmp/reviewboard.IBoaWc' for debugging purposes. `patch` returned: patching
file /tmp/reviewboard.IBoaWc/tmpWoRpsq Hunk #1 FAILED at 98. 1 out of 1 hunk
FAILED -- saving rejects to file /tmp/reviewboard.IBoaWc/tmpWoRpsq-new.rej
D
On Fri, Apr 1, 2011 at 6:22 PM, Daniel Dai <da...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/544/
> -----------------------------------------------------------
>
> Review request for pig and thejas.
>
>
> Summary
> -------
>
> The following script produce wrong result:
>
> data = LOAD 'data.txt' using PigStorage() as (referrer:chararray,
> canonical_url:chararray, ip:chararray);
> best_url = FOREACH data GENERATE ((canonical_url != '' and canonical_url is
> not null) ? canonical_url : referrer) AS url, ip;
> filtered = FILTER best_url BY url == 'badsite.com';
> dump filtered;
>
> data.txt:
> badsite.com 127.0.0.1
> goodsite.com/1?foo=true goodsite.com 127.0.0.1
>
> Expected:
> (badsite.com,127.0.0.1)
>
> We get nothing.
>
>
> Diffs
> -----
>
>
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java1085215
>
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterAboveForeach.java1085215
>
> Diff: https://reviews.apache.org/r/544/diff
>
>
> Testing
> -------
>
> test-patch:
> [exec] +1 overall.
> [exec]
> [exec] +1 @author. The patch does not contain any @author tags.
> [exec]
> [exec] +1 tests included. The patch appears to include 3 new or
> modified tests.
> [exec]
> [exec] +1 javadoc. The javadoc tool did not generate any warning
> messages.
> [exec]
> [exec] +1 javac. The applied patch does not increase the total
> number of javac compiler warnings.
> [exec]
> [exec] +1 findbugs. The patch does not introduce any new Findbugs
> warnings.
> [exec]
> [exec] +1 release audit. The applied patch does not increase the
> total number of release audit warnings.
>
> Unit test:
> all pass
>
> End-to-end test:
> all pass
>
>
> Thanks,
>
> Daniel
>
>