You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/01/07 13:46:13 UTC
[GitHub] [hbase] dasanjan1296 opened a new pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
dasanjan1296 opened a new pull request #2855:
URL: https://github.com/apache/hbase/pull/2855
- This is to address post-merge feedback from #2844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-757409380
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 22s | master passed |
| +1 :green_heart: | compile | 0m 59s | master passed |
| +1 :green_heart: | shadedjars | 7m 10s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 51s | the patch passed |
| +1 :green_heart: | compile | 0m 59s | the patch passed |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 8s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 8m 46s | hbase-server in the patch failed. |
| | | 36m 51s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2855 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 366df677ab3d 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 686b72c44e |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/3/testReport/ |
| Max. process+thread count | 441 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-756228533
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 22s | master passed |
| +1 :green_heart: | compile | 1m 5s | master passed |
| +1 :green_heart: | shadedjars | 6m 38s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 42s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 3s | the patch passed |
| +1 :green_heart: | compile | 1m 7s | the patch passed |
| +1 :green_heart: | javac | 1m 7s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 41s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 141m 39s | hbase-server in the patch passed. |
| | | 169m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2855 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 54e4ba6a9afa 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4b6215297d |
| Default Java | AdoptOpenJDK-11.0.6+10 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/1/testReport/ |
| Max. process+thread count | 4523 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-757418397
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 22s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 26s | master passed |
| +1 :green_heart: | compile | 1m 6s | master passed |
| +1 :green_heart: | shadedjars | 6m 37s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 42s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 6s | the patch passed |
| +1 :green_heart: | compile | 1m 7s | the patch passed |
| +1 :green_heart: | javac | 1m 7s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 37s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 40s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 96m 28s | hbase-server in the patch failed. |
| | | 125m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2855 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 83a47859349f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 686b72c44e |
| Default Java | AdoptOpenJDK-11.0.6+10 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/3/testReport/ |
| Max. process+thread count | 4079 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-757093725
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 4s | master passed |
| +1 :green_heart: | checkstyle | 1m 6s | master passed |
| +1 :green_heart: | spotbugs | 2m 11s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 38s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 6s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 18m 46s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 21s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
| | | 41m 51s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2855 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 800a30cdeb08 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4925a6422b |
| Max. process+thread count | 94 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/2/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-757101059
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 23s | master passed |
| +1 :green_heart: | compile | 1m 6s | master passed |
| +1 :green_heart: | shadedjars | 6m 48s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 42s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 4s | the patch passed |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 42s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 87m 4s | hbase-server in the patch failed. |
| | | 115m 5s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2855 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux d2e70ec96172 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4925a6422b |
| Default Java | AdoptOpenJDK-11.0.6+10 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/2/testReport/ |
| Max. process+thread count | 1997 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] dasanjan1296 commented on a change in pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
dasanjan1296 commented on a change in pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#discussion_r554285615
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java
##########
@@ -131,14 +131,14 @@ public void testWALArchiveWithDifferentWalAndRootFS() throws Exception{
}
executor.submitProcedure(splitProcedure);
LOG.info("Submitted SplitProcedure.");
- test_util_2.waitFor(30000, () -> executor.getProcedures().stream()
- .filter(p -> p instanceof TransitRegionStateProcedure)
- .map(p -> (TransitRegionStateProcedure) p)
- .anyMatch(p -> TABLE_NAME.equals(p.getTableName())));
- test_util_2.getMiniHBaseCluster().killRegionServer(
- test_util_2.getMiniHBaseCluster().getRegionServer(0).getServerName());
- test_util_2.getMiniHBaseCluster().startRegionServer();
- test_util_2.waitUntilNoRegionsInTransition();
+ testUtil2.waitFor(30000, () -> executor.getProcedures().stream()
+ .filter(p -> p instanceof SplitTableRegionProcedure)
+ .map(p -> (SplitTableRegionProcedure) p)
+ .anyMatch(p -> TABLE_NAME.equals(p.getTableName())) && splitProcedure.isSuccess());
+ testUtil2.getMiniHBaseCluster().killRegionServer(
+ testUtil2.getMiniHBaseCluster().getRegionServer(0).getServerName());
+ testUtil2.getMiniHBaseCluster().startRegionServer();
+ testUtil2.waitUntilNoRegionsInTransition();
Review comment:
Yes, I agree with you. Simply doing a split wal operation should be enough to test this particular scenario. I went overboard with the test while trying to explore a few things. I've updated the test per your suggestion. PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-757093182
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 1s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 12s | master passed |
| +1 :green_heart: | compile | 0m 59s | master passed |
| +1 :green_heart: | shadedjars | 7m 12s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 50s | the patch passed |
| +1 :green_heart: | compile | 0m 59s | the patch passed |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 11s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 8m 42s | hbase-server in the patch failed. |
| | | 36m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2855 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 25fb713c7e2c 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4925a6422b |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/2/testReport/ |
| Max. process+thread count | 432 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] wchevreuil commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-757868734
retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] wchevreuil commented on a change in pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on a change in pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#discussion_r553891216
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java
##########
@@ -131,14 +131,14 @@ public void testWALArchiveWithDifferentWalAndRootFS() throws Exception{
}
executor.submitProcedure(splitProcedure);
LOG.info("Submitted SplitProcedure.");
- test_util_2.waitFor(30000, () -> executor.getProcedures().stream()
- .filter(p -> p instanceof TransitRegionStateProcedure)
- .map(p -> (TransitRegionStateProcedure) p)
- .anyMatch(p -> TABLE_NAME.equals(p.getTableName())));
- test_util_2.getMiniHBaseCluster().killRegionServer(
- test_util_2.getMiniHBaseCluster().getRegionServer(0).getServerName());
- test_util_2.getMiniHBaseCluster().startRegionServer();
- test_util_2.waitUntilNoRegionsInTransition();
+ testUtil2.waitFor(30000, () -> executor.getProcedures().stream()
+ .filter(p -> p instanceof SplitTableRegionProcedure)
+ .map(p -> (SplitTableRegionProcedure) p)
+ .anyMatch(p -> TABLE_NAME.equals(p.getTableName())) && splitProcedure.isSuccess());
+ testUtil2.getMiniHBaseCluster().killRegionServer(
+ testUtil2.getMiniHBaseCluster().getRegionServer(0).getServerName());
+ testUtil2.getMiniHBaseCluster().startRegionServer();
+ testUtil2.waitUntilNoRegionsInTransition();
Review comment:
Test looks fine, functionally wise, but could we simplify it and make it more clear by directly testing the log splitting? Sorry, don't want to be picky, it just looks we are doing more than needed here, maybe it would be simpler to just to do same thing as `testSplitLogs()`, after making sure wal is under a different file system. You could move current `testSplitLogs()` to a separate method that would be called by both this test and `testSplitLogs`.
WDYT, @dasanjan1296 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] wchevreuil removed a comment on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
wchevreuil removed a comment on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-757868734
retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-757093182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] dasanjan1296 commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
dasanjan1296 commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-756126132
@wchevreuil Thanks for the feedback on #2844. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani merged pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
virajjasani merged pull request #2855:
URL: https://github.com/apache/hbase/pull/2855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] dasanjan1296 commented on a change in pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
dasanjan1296 commented on a change in pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#discussion_r554285615
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java
##########
@@ -131,14 +131,14 @@ public void testWALArchiveWithDifferentWalAndRootFS() throws Exception{
}
executor.submitProcedure(splitProcedure);
LOG.info("Submitted SplitProcedure.");
- test_util_2.waitFor(30000, () -> executor.getProcedures().stream()
- .filter(p -> p instanceof TransitRegionStateProcedure)
- .map(p -> (TransitRegionStateProcedure) p)
- .anyMatch(p -> TABLE_NAME.equals(p.getTableName())));
- test_util_2.getMiniHBaseCluster().killRegionServer(
- test_util_2.getMiniHBaseCluster().getRegionServer(0).getServerName());
- test_util_2.getMiniHBaseCluster().startRegionServer();
- test_util_2.waitUntilNoRegionsInTransition();
+ testUtil2.waitFor(30000, () -> executor.getProcedures().stream()
+ .filter(p -> p instanceof SplitTableRegionProcedure)
+ .map(p -> (SplitTableRegionProcedure) p)
+ .anyMatch(p -> TABLE_NAME.equals(p.getTableName())) && splitProcedure.isSuccess());
+ testUtil2.getMiniHBaseCluster().killRegionServer(
+ testUtil2.getMiniHBaseCluster().getRegionServer(0).getServerName());
+ testUtil2.getMiniHBaseCluster().startRegionServer();
+ testUtil2.waitUntilNoRegionsInTransition();
Review comment:
Yes, I agree with you. Simply doing a split wal operation should be enough to test this particular scenario. I went overboard with the test while trying to explore a few things. I've updated the test per your suggestion. PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] wchevreuil commented on a change in pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on a change in pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#discussion_r553891216
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java
##########
@@ -131,14 +131,14 @@ public void testWALArchiveWithDifferentWalAndRootFS() throws Exception{
}
executor.submitProcedure(splitProcedure);
LOG.info("Submitted SplitProcedure.");
- test_util_2.waitFor(30000, () -> executor.getProcedures().stream()
- .filter(p -> p instanceof TransitRegionStateProcedure)
- .map(p -> (TransitRegionStateProcedure) p)
- .anyMatch(p -> TABLE_NAME.equals(p.getTableName())));
- test_util_2.getMiniHBaseCluster().killRegionServer(
- test_util_2.getMiniHBaseCluster().getRegionServer(0).getServerName());
- test_util_2.getMiniHBaseCluster().startRegionServer();
- test_util_2.waitUntilNoRegionsInTransition();
+ testUtil2.waitFor(30000, () -> executor.getProcedures().stream()
+ .filter(p -> p instanceof SplitTableRegionProcedure)
+ .map(p -> (SplitTableRegionProcedure) p)
+ .anyMatch(p -> TABLE_NAME.equals(p.getTableName())) && splitProcedure.isSuccess());
+ testUtil2.getMiniHBaseCluster().killRegionServer(
+ testUtil2.getMiniHBaseCluster().getRegionServer(0).getServerName());
+ testUtil2.getMiniHBaseCluster().startRegionServer();
+ testUtil2.waitUntilNoRegionsInTransition();
Review comment:
Test looks fine, functionally wise, but could we simplify it and make it more clear by directly testing the log splitting? Sorry, don't want to be picky, it just looks we are doing more than needed here, maybe it would be simpler to just to do same thing as `testSplitLogs()`, after making sure wal is under a different file system. You could move current `testSplitLogs()` to a separate method that would be called by both this test and `testSplitLogs`.
WDYT, @dasanjan1296 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-756149468
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 53s | master passed |
| +1 :green_heart: | checkstyle | 1m 5s | master passed |
| +1 :green_heart: | spotbugs | 1m 59s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 28s | the patch passed |
| -0 :warning: | checkstyle | 1m 4s | hbase-server: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 18m 40s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 14s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 40m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2855 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 7e3645b130b9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4b6215297d |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 94 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/1/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#issuecomment-756297281
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 2s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 10s | master passed |
| +1 :green_heart: | compile | 1m 0s | master passed |
| +1 :green_heart: | shadedjars | 7m 12s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 51s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 11s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 254m 29s | hbase-server in the patch passed. |
| | | 283m 4s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2855 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux cd3c8449b999 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4b6215297d |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/1/testReport/ |
| Max. process+thread count | 2817 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2855/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org