You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/08/23 00:24:33 UTC
Review Request 71357: Used boost `small_vector` in `Resources`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71357/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9806
https://issues.apache.org/jira/browse/MESOS-9806
Repository: mesos
Description
-------
Without this patch:
*HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Made 3500 allocations in 22.065721878secs
Made 0 allocation in 19.467366742secs
With this patch:
*HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Made 3500 allocations in 20.58648254secs
Made 0 allocation in 17.705055744secs
Diffs
-----
include/mesos/resources.hpp e5e87a04b42ebd277d02100dd49b8e2ce98fdc04
include/mesos/v1/resources.hpp 6a9751af967ed29ae77dc1c3e34453a306eae9d2
Diff: https://reviews.apache.org/r/71357/diff/1/
Testing
-------
make check
Benchmark result in the description
Thanks,
Meng Zhu
Re: Review Request 71357: Used boost `small_vector` in `Resources`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71357/#review217415
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/resources.hpp
Lines 636-647 (original), 637-650 (patched)
<https://reviews.apache.org/r/71357/#comment304696>
Ditto here from last review, seems like there's probably a cleaner way to get the const-ness?
include/mesos/v1/resources.hpp
Lines 756 (patched)
<https://reviews.apache.org/r/71357/#comment304697>
Can we document how we came up with 15 or what 15 can handle?
E.g. up to unreserved of 5 first class resources + 2 reservations of 5 first class resources
- Benjamin Mahler
On Aug. 23, 2019, 7:44 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71357/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2019, 7:44 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9806
> https://issues.apache.org/jira/browse/MESOS-9806
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Master + previous patch:
> *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> Made 3500 allocations in 16.307044003secs
> Made 0 allocation in 14.948262599secs
>
> Master + previous patch + this patch:
> *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> Made 3500 allocations in 15.385276405secs
> Made 0 allocation in 13.718502414secs
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp e5e87a04b42ebd277d02100dd49b8e2ce98fdc04
> include/mesos/v1/resources.hpp 6a9751af967ed29ae77dc1c3e34453a306eae9d2
>
>
> Diff: https://reviews.apache.org/r/71357/diff/2/
>
>
> Testing
> -------
>
> make check
> Benchmark result in the description
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71357: Used boost `small_vector` in `Resources`.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71357/
-----------------------------------------------------------
(Updated Aug. 23, 2019, 12:44 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9806
https://issues.apache.org/jira/browse/MESOS-9806
Repository: mesos
Description (updated)
-------
Master + previous patch:
*HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Made 3500 allocations in 16.307044003secs
Made 0 allocation in 14.948262599secs
Master + previous patch + this patch:
*HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Made 3500 allocations in 15.385276405secs
Made 0 allocation in 13.718502414secs
Diffs (updated)
-----
include/mesos/resources.hpp e5e87a04b42ebd277d02100dd49b8e2ce98fdc04
include/mesos/v1/resources.hpp 6a9751af967ed29ae77dc1c3e34453a306eae9d2
Diff: https://reviews.apache.org/r/71357/diff/2/
Changes: https://reviews.apache.org/r/71357/diff/1-2/
Testing
-------
make check
Benchmark result in the description
Thanks,
Meng Zhu