Re: [JIRA](ISSUE #FLEX-28291) Dev review request

[Mihai Chira <mi...@gmail.com>]

Chris, thanks for the review. I finally acted on it and converted the
tabs to spaces :)

On 3 September 2014 17:14, Chris Martin <wi...@gmail.com> wrote:
> Found this little gem a bit ago.  It can take some doing to fund, but it's
> in the Guides and References section on the wiki.
>
> https://cwiki.apache.org/confluence/display/FLEX/Flex+SDK+coding+conventions+and+best+practices
>
> From there looks like we use 4 spaces
>
> "Indentation
>
> Use 4-space indentation. Configure your text editor to insert spaces rather
> than tabs. This allows another program that uses a different indentation
> setting, such as Notepad with its 8-character indents, to display the code
> without disfiguring it."
>
>
> Chris
>
>
> On Wed, Sep 3, 2014 at 8:26 AM, Mihai Chira <mi...@gmail.com> wrote:
>
>> It looked good in FlashBuilder before committing, strange.
>>
>> Ok, it's because before every other line there are 8 spaces, and
>> before the new ones I added there are two tabs. It appears that both
>> FishEye and Github have an 8space/tab setting... Do we have a policy
>> on this? I imagine that for most developers this will look well in
>> their editors - or do many folks have a different space/tab setting
>> than 4?
>>
>> On 3 September 2014 15:02, Tom Chiverton <tc...@extravision.com> wrote:
>> > I dunno if it's just FishEye, but the indentation is confusing -
>> > updateLLV(g) appears under the if, but the if has no brackets.
>> >
>> > Tom
>> >
>> > On 03/09/14 12:27, Mihai Chira wrote:
>> >> If anyone has time to review this bug fix, it would be very helpful.
>> >>
>> >> You can comment on github and let me know here.
>> >>
>> >> Thanks.
>> >>
>> >> ______________________________________________________________________
>> >> This email has been scanned by the Symantec Email Security.cloud
>> service.
>> >> For more information please visit http://www.symanteccloud.com
>> >> ______________________________________________________________________
>> >>
>> >
>>