[jira] [Commented] (AMQ-6908) Inconsistent authorization in web console

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402363#comment-16402363 ] 

ASF GitHub Bot commented on AMQ-6908:
-------------------------------------

GitHub user alvinlin123 opened a pull request:

    https://github.com/apache/activemq/pull/280

    AMQ-6908 Use WebClient in QueueBrowseQuery

    `org.apache.activemq.web.controller.SendMessage` uses `org.apache.activemq.web.WebClient`, which can be configured to use console login credential instead of system user credential (by setting the connection factory username and password to `null`). This allows seamless per-user based authorization for operations through the web console. 
    
    `org.apache.activemq.web.QueueBrowseQuery` was not using the `org.apache.activemq.web.WebClient` so it was impossible to setup authorization on per-user basis for browsing messages of a queue through web console. 
    
    This change migrates `org.apache.activemq.web.QueueBrowseQuery` to use `org.apache.activemq.web.WebClient`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alvinlin123/activemq amq-6908

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #280
    
----
commit 822cf6203437f06a58e8e442de87b8416ad232e6
Author: Alvin Lin <al...@...>
Date:   2018-03-16T18:30:05Z

    AMQ-6908 allow use of ActiveMQ console login credential (for authorization) when browsing messages through the console

----


> Inconsistent authorization in web console
> -----------------------------------------
>
>                 Key: AMQ-6908
>                 URL: https://issues.apache.org/jira/browse/AMQ-6908
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: webconsole
>    Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>            Reporter: Alvin Lin
>            Priority: Major
>
> Looking at org.apache.activemq.web.WebClient#createWebClient we can actually configure the connectionFactory in webconsle-embedded.xml to use the credential in the HTTP Authorization header to connect to the core ActiveMQ broker by setting the username and password to null.
> But when I do that, the browse in console feature stops working if I have authentication enabled, because org.apache.activemq.web.QueueBrowseQuery requires the given connectionFactory to be configured with non-null username and password. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)