You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by markap14 <gi...@git.apache.org> on 2016/06/29 19:15:04 UTC

[GitHub] nifi pull request #593: NIFI-2150: Cleanse more values from templates that a...

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/593

    NIFI-2150: Cleanse more values from templates that are not necessary.\u2026

    \u2026 Additionally, updated javadocs in ProcessorConfigDTO to provide further explanation of the getAutoTerminatedRelationships() method, since this was confusing

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-2150

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/593.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #593
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #593: NIFI-2150: Cleanse more values from templates that are not ...

Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/593
  
    @mcgilman good call. Looks good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #593: NIFI-2150: Cleanse more values from templates that are not ...

Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/593
  
    @markap14 Looks great! I made one additional change to populate snippet results off of the actual components instead of just the snippet contents (since the contents are now pruned).
    
    https://github.com/mcgilman/nifi/commit/1b8d231cedbf192fd1027a5a3913fd04b525cc0f


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #593: NIFI-2150: Cleanse more values from templates that are not ...

Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/593
  
    Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #593: NIFI-2150: Cleanse more values from templates that are not ...

Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/593
  
    Just glancing through an old template and looks like we should also be scrubbing the following...
    
    - Process Group
    -- activeRemotePortCount, disabledCount, inactiveRemotePortCount, inputPortCount, invalidCount, outputPortCount, runningCount, stoppedCount
    - Remote Process Group
    -- activeRemoteInputPortCount, activeRemoteOutputPortCount, inactiveRemoteInputPortCount, inactiveRemoteOutputPortCount, name
    - Root Group Port
    -- transmitting, validationErrors


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #593: NIFI-2150: Cleanse more values from templates that are not ...

Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/593
  
    @mcgilman good call! I also found a few more things for these components that we don't need. I have pushed a new commit so that you can look at it and make sure that the changes all make sense to you, as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #593: NIFI-2150: Cleanse more values from templates that a...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/593


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---