You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by laurentgo <gi...@git.apache.org> on 2017/03/03 04:09:20 UTC

[GitHub] drill pull request #769: DRILL-5313: Fix compilation issue in C++ connector

GitHub user laurentgo opened a pull request:

    https://github.com/apache/drill/pull/769

    DRILL-5313: Fix compilation issue in C++ connector

    DRILL-5301 and DRILL-5167 have conflicting changes, which causes
    the C++ connector to not compile: the static symbol for the search
    escape string has been removed as the server might use a different one.
    
    Fix the issue by using the current search escape string (injected from the
    meta to the internal drill client when querying metadata).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/drill laurent/DRILL-5313

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/769.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #769
    
----
commit 795bdf53070ba2d20d65f23f0313b2777e334611
Author: Laurent Goujon <la...@dremio.com>
Date:   2017-03-03T04:03:42Z

    DRILL-5313: Fix compilation issue in C++ connector
    
    DRILL-5301 and DRILL-5167 have conflicting changes, which causes
    the C++ connector to not compile: the static symbol for the search
    escape string has been removed as the server might use a different one.
    
    Fix the issue by using the current search escape string (injected from the
    meta to the internal drill client when querying metadata).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #769: DRILL-5313: Fix compilation issue in C++ connector

Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the issue:

    https://github.com/apache/drill/pull/769
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #769: DRILL-5313: Fix compilation issue in C++ connector

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/769


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #769: DRILL-5313: Fix compilation issue in C++ connector

Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the issue:

    https://github.com/apache/drill/pull/769
  
    Built, and sanity tested using querySubmitter test application.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---