You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mb...@apache.org on 2022/02/26 00:00:38 UTC

[asterixdb] 02/10: [NO ISSUE][STO] Fix write rate limiter calculation

This is an automated email from the ASF dual-hosted git repository.

mblow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git

commit f9152062cf3126d6aa45062e19a7cb2fd96aeb58
Author: Murtadha Hubail <mu...@couchbase.com>
AuthorDate: Tue Feb 15 00:15:08 2022 +0300

    [NO ISSUE][STO] Fix write rate limiter calculation
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    
    - Fix the write request size to the write rate limiter
      by considering the page size.
    
    Change-Id: If875755d65476339b90adcf6e654e32e97655f3d
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15286
    Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Tested-by: Murtadha Hubail <mh...@apache.org>
    Reviewed-by: Murtadha Hubail <mh...@apache.org>
    Reviewed-by: Ali Alsuliman <al...@gmail.com>
---
 .../hyracks/storage/am/lsm/common/impls/LSMIndexPageWriteCallback.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexPageWriteCallback.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexPageWriteCallback.java
index 0ad7033..85a2d39 100644
--- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexPageWriteCallback.java
+++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexPageWriteCallback.java
@@ -43,7 +43,7 @@ public class LSMIndexPageWriteCallback implements IPageWriteCallback {
     }
 
     public void beforeWrite(ICachedPage page) throws HyracksDataException {
-        rateLimiter.request(page.getFrameSizeMultiplier());
+        rateLimiter.request(page.getPageSize() * page.getFrameSizeMultiplier());
     }
 
     @Override