You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/06/09 23:36:22 UTC
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6892: Add cache config generation comment header blank line
ocket8888 commented on code in PR #6892:
URL: https://github.com/apache/trafficcontrol/pull/6892#discussion_r894026520
##########
lib/go-atscfg/parentdotconfig_test.go:
##########
@@ -258,8 +258,8 @@ func TestMakeParentDotConfigCapabilities(t *testing.T) {
lines := strings.Split(txt, "\n")
- if len(lines) != 4 {
- t.Fatalf("expected 4 lines (comment, ds, dot remap, and empty newline), actual: '%+v' text %v", len(lines), txt)
+ if len(lines) != 5 {
+ t.Fatalf("expected 4 lines (comment, blank, ds, dot remap, and empty newline), actual: '%+v' text %v", len(lines), txt)
Review Comment:
This expectation is changed; "expected <del>4</del><ins>5</ins> lines..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -2207,15 +2207,15 @@ func TestMakeRemapDotConfigEdgeHostRegexReplacementHTTP(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 {
t.Fatalf("expected 1 remap from HTTP DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remap<ins>s</ins> from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -3463,11 +3463,11 @@ func TestMakeRemapDotConfigEdgeSigningURISigning(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -4476,11 +4476,11 @@ func TestMakeRemapDotConfigEdgeCacheKeyParams(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -5971,11 +5971,11 @@ func TestMakeRemapDotConfigEdgeRangeRequestCache(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -2697,11 +2697,11 @@ func TestMakeRemapDotConfigEdgeDSCPRemap(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -2329,15 +2329,15 @@ func TestMakeRemapDotConfigEdgeHostRegexReplacementHTTPS(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remap<ins>s</ins> from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -2085,15 +2085,15 @@ func TestMakeRemapDotConfigEdgeHostRegexReplacement(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 3 {
+ if len(txtLines) != 4 {
t.Fatalf("expected 3 remaps from HTTP_AND_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>3</del><ins>4</ins> remaps from ..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -2451,15 +2451,15 @@ func TestMakeRemapDotConfigEdgeHostRegexReplacementHTTPToHTTPS(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remap<ins>s</ins> from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -6339,11 +6339,11 @@ func TestMakeRemapDotConfigEdgeFQPacingZero(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -2573,11 +2573,11 @@ func TestMakeRemapDotConfigEdgeRemapUnderscoreHTTPReplace(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -2945,11 +2945,11 @@ func TestMakeRemapDotConfigEdgeHeaderRewrite(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -2821,11 +2821,11 @@ func TestMakeRemapDotConfigEdgeNoDSCPRemap(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -3073,11 +3073,11 @@ func TestMakeRemapDotConfigEdgeHeaderRewriteEmpty(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -3335,11 +3335,11 @@ func TestMakeRemapDotConfigEdgeSigningURLSig(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -3709,11 +3709,11 @@ func TestMakeRemapDotConfigEdgeSigningEmpty(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -3586,11 +3586,11 @@ func TestMakeRemapDotConfigEdgeSigningNone(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -3832,11 +3832,11 @@ func TestMakeRemapDotConfigEdgeSigningWrong(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/storagedotconfig_test.go:
##########
@@ -154,7 +154,7 @@ func TestMakeStorageDotConfigNoDriveLetters(t *testing.T) {
testComment(t, txt, hdr)
- if count := strings.Count(txt, "\n"); count != 2 { // comment plus a blank line
+ if count := strings.Count(txt, "\n"); count != 3 { // comment plus its blank plus a blank line
t.Errorf("expected one line for comment, plus one blank line (it's important to send a blank line, to prevent many callers from returning a 404), actual: '"+txt+"' count %v", count)
Review Comment:
> ... plus one blank line <ins>and another blank line</ins> ...
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -3955,11 +3955,11 @@ func TestMakeRemapDotConfigEdgeQStringDropAtEdge(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -3201,11 +3201,11 @@ func TestMakeRemapDotConfigEdgeHeaderRewriteNil(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/storagedotconfig_test.go:
##########
@@ -112,7 +112,7 @@ func TestMakeStorageDotConfigNoParams(t *testing.T) {
testComment(t, txt, hdr)
- if count := strings.Count(txt, "\n"); count != 2 { // comment plus a blank line
+ if count := strings.Count(txt, "\n"); count != 3 { // comment header plus its blank plus a blank line
t.Errorf("expected one line for comment, plus one blank line (it's important to send a blank line, to prevent many callers from returning a 404), actual: '"+txt+"' count %v", count)
Review Comment:
> ... plus one blank line <ins>and another blank line</ins> ...
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -4212,11 +4212,11 @@ func TestMakeRemapDotConfigEdgeQStringIgnorePassUpWithCacheKeyParameter(t *testi
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -7984,7 +7984,12 @@ func TestMakeRemapDotConfigMidLastRawRemap(t *testing.T) {
t.Fatalf("expected [1] as comment, actual: \n'%v' got %v", txt, commentstr)
}
- firststr := txtLines[1]
+ blankStr := txtLines[1]
+ if strings.TrimSpace(blankStr) != "" {
+ t.Fatalf("expected [1] as blank line after comment, actual: \n'%v' got %v", txt, commentstr)
+ }
+
+ firststr := txtLines[2]
if !strings.Contains(firststr, "firstraw") {
t.Fatalf("expected [1] with 'firstraw', actual: '%v' got %v", txt, firststr)
Review Comment:
> "expected [<del>1</del><ins>2</ins>] with..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -7589,11 +7589,11 @@ func TestMakeRemapDotConfigEdgeHTTPSOriginHTTPRemapTopology(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -4340,11 +4340,11 @@ func TestMakeRemapDotConfigEdgeQStringIgnorePassUpCacheURLParamCacheURL(t *testi
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -4076,11 +4076,11 @@ func TestMakeRemapDotConfigEdgeQStringIgnorePassUp(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/storagedotconfig_test.go:
##########
@@ -197,7 +197,7 @@ func TestMakeStorageDotConfigSomeDriveLetters(t *testing.T) {
testComment(t, txt, hdr)
- if count := strings.Count(txt, "\n"); count != 6 { // comment plus each letter
+ if count := strings.Count(txt, "\n"); count != 7 { // comment plus blank plus each letter
t.Errorf("expected one line for comment, plus one line for each drive letter, actual: '"+txt+"' count %v", count)
Review Comment:
> ... for comment, <ins>plus a blank line,</ins> ...
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -7774,11 +7774,11 @@ func TestMakeRemapDotConfigMidHTTPSOriginHTTPRemapTopology(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -4847,11 +4847,11 @@ func TestMakeRemapDotConfigEdgeRangeRequestNil(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -4603,11 +4603,11 @@ func TestMakeRemapDotConfigEdgeRegexRemap(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -5265,11 +5265,11 @@ func TestMakeRemapDotConfigEdgeRangeRequestSlice(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -5132,11 +5132,11 @@ func TestMakeRemapDotConfigEdgeRangeRequestBGFetch(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -4987,11 +4987,11 @@ func TestMakeRemapDotConfigEdgeRangeRequestDontCache(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -4727,11 +4727,11 @@ func TestMakeRemapDotConfigEdgeRegexRemapEmpty(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -5545,11 +5545,11 @@ func TestMakeRemapDotConfigEdgeRangeRequestSlicePparam(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -6099,11 +6099,11 @@ func TestMakeRemapDotConfigEdgeFQPacingNil(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -6219,11 +6219,11 @@ func TestMakeRemapDotConfigEdgeFQPacingNegative(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -6459,11 +6459,11 @@ func TestMakeRemapDotConfigEdgeFQPacingPositive(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -5686,11 +5686,11 @@ func TestMakeRemapDotConfigRawRemapRangeDirective(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 3 { // 2 remaps plus header comment
+ if len(txtLines) != 4 { // 2 remaps plus header comment plus blank
t.Fatalf("expected 2 remaps from HTTP_AND_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>2</del><ins>4</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -5832,11 +5832,11 @@ func TestMakeRemapDotConfigRawRemapWithoutRangeDirective(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -6583,11 +6583,11 @@ func TestMakeRemapDotConfigEdgeDNS(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -5400,11 +5400,11 @@ func TestMakeRemapDotConfigMidRangeRequestSlicePparam(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -6928,11 +6928,11 @@ func TestMakeRemapDotConfigNoHeaderRewrite(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -7048,11 +7048,11 @@ func TestMakeRemapDotConfigMidNoHeaderRewrite(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -7284,11 +7284,11 @@ func TestMakeRemapDotConfigEdgeHTTPSOriginHTTPRemap(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -7416,11 +7416,11 @@ func TestMakeRemapDotConfigMidHTTPSOriginHTTPRemap(t *testing.T) {
txtLines := strings.Split(txt, "\n")
- if len(txtLines) != 2 {
+ if len(txtLines) != 3 { // comment, blank, and remap
t.Fatalf("expected 1 remaps from HTTP_TO_HTTPS DS, actual: '%v' count %v", txt, len(txtLines))
Review Comment:
> "expected <del>1</del><ins>3</ins> remaps from..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org