You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by wary <gi...@git.apache.org> on 2017/04/11 15:28:35 UTC

[GitHub] zeppelin pull request #2242: Improvement

GitHub user wary opened a pull request:

    https://github.com/apache/zeppelin/pull/2242

    Improvement

    Improve the spark sql interpreter to run paragraph with multi sql statements split by semicolon
    
    ### What is this PR for?
    A few sentences describing the overall goals of the pull request's commits.
    First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
    
    * Improve the spark sql interpreter to run paragraph with multi sql statements split by semicolon
    In current version of Zeppelin, we can only run one sql statement in one paragraph, that is very inconvenient\uff0cso I think we need to improve the spark sql interpreter to fix this problem
    
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
    [ZEPPELIN-2392](https://issues.apache.org/jira/browse/ZEPPELIN-2392)
    ### How should this be tested?
    Outline the steps to test the PR here.
    
    ### Screenshots (if appropriate)
    <img width="1362" alt="2017-04-11 11 03 46" src="https://cloud.githubusercontent.com/assets/869480/24916697/72d9cf24-1f0d-11e7-8a68-50ba9973fcb8.png">
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wary/zeppelin SparkSqlInterpreterEnhancement

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2242
    
----
commit 4b06a9e667c0ab3d32aa122766998ca2f6d938f7
Author: lei wang <le...@outlook.com>
Date:   2017-04-11T15:18:14Z

    Improvement
    
    improve the spark sql interpreter to run paragraph with multi sql statements split by semicolon

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2242: Improve the spark sql interpreter to run paragraph wit...

Posted by wary <gi...@git.apache.org>.

Github user wary commented on the issue:

    https://github.com/apache/zeppelin/pull/2242
  
    @tinkoff-dwh oh, yes, you are right, I did not see that, thank you for reminding, I will close this pull request and reconsidered it 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2242: Improve the spark sql interpreter to run paragraph wit...

Posted by tinkoff-dwh <gi...@git.apache.org>.

Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2242
  
    why returns only last result? jdbc interpreter has method (splitSqlQueries) maybe do refactoring (general method to split + result for each request). And add test (jdbc interpreter has test)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2242: Improve the spark sql interpreter to run paragr...

Posted by wary <gi...@git.apache.org>.

Github user wary closed the pull request at:

    https://github.com/apache/zeppelin/pull/2242


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---