[GitHub] [activemq] cshannon commented on pull request #965: [AMQ-9217] Add config flag to support per-destination audit in AbstractDeadLetterStrategy

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on PR #965:
URL: https://github.com/apache/activemq/pull/965#issuecomment-1420634443

   Also, I am wondering if this change should actually have a flag at all..seems like it's just a bug and should be fixed for IndividualDeadLetterStrategy. I think the only thing that really makes sense is to have an audit per DLQ destination.
   
   If a user has enabled a DLQ per destination and are using something like Virtual Topics it is pretty weird to only DLQ one of the messages to one of the destinations if there are several consumer queues and more than one consumer caused the message to go to the DLQ. I guess someone reading the DLQ could be using a wildcard consumer so they would end up with duplicates which is a behavior change but if doing that then it would make more sense to use the shared strategy.
   
   Maybe for a future release (like 5.18.0 or 5.19.0) for 5.18.0 we change the default behavior so that the individual strategy defaults to using an audit per destination as that seems like the more "correct" thing to do while keeping a flag to disable it i guess.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org