[GitHub] [flink] tillrohrmann commented on a change in pull request #17240: [FLINK-24255][tests] Test environments respect configuration when being instantiated

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #17240:
URL: https://github.com/apache/flink/pull/17240#discussion_r721469849



##########
File path: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterPipelineExecutorServiceLoader.java
##########
@@ -61,8 +61,7 @@ public MiniClusterPipelineExecutorServiceLoader(MiniCluster miniCluster) {
      * MiniClusterPipelineExecutorServiceLoader}.
      */
     public static Configuration createConfiguration(
-            Collection<Path> jarFiles, Collection<URL> classPaths) {
-        Configuration config = new Configuration();
+            Configuration config, Collection<Path> jarFiles, Collection<URL> classPaths) {

Review comment:
       Maybe we could also rename the method to `updateConfiguration`/`prepareConfigurationForMiniClusterExecution` or something better because now the method no longer creates a configuration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org