You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/01/04 13:50:07 UTC

[GitHub] [incubator-echarts] LianJilu opened a new pull request #11976: Fix #11042 add cross-shaped color to candlestick

LianJilu opened a new pull request #11976: Fix #11042 add cross-shaped color to candlestick
URL: https://github.com/apache/incubator-echarts/pull/11976
 
 
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   
   
   ### What does this PR do?
   
   add cross-shaped color to candlestick when the openVal equal closeVal
   
   
   
   ### Fixed issues
   
   #11042
   
   
   ## Details
   
   ### Before: What was the problem?
   
   can not set the cross color(when the open value equal close value)
   
   
   
   ### After: How is it fixed in this PR?
   
   set cross-shaped color 
   the default color is '#000' and '#FFF'(dark theme)
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   series-candlestick.itemStyle.color1: 
   series-candlestick.itemStyle.borderColor1
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] LianJilu commented on issue #11976: Fix #11042 add cross-shaped color to candlestick

Posted by GitBox <gi...@apache.org>.
LianJilu commented on issue #11976: Fix #11042 add cross-shaped color to candlestick
URL: https://github.com/apache/incubator-echarts/pull/11976#issuecomment-570789504
 
 
   > You don't need to submit echart.js and echarts.js.map
   
   ok, i will pull the master and recommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] susiwen8 commented on issue #11976: Fix #11042 add cross-shaped color to candlestick

Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #11976: Fix #11042 add cross-shaped color to candlestick
URL: https://github.com/apache/incubator-echarts/pull/11976#issuecomment-570787503
 
 
   You don't need to submit echart.js and echarts.js.map

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] LianJilu closed pull request #11976: Fix #11042 add cross-shaped color to candlestick

Posted by GitBox <gi...@apache.org>.
LianJilu closed pull request #11976: Fix #11042 add cross-shaped color to candlestick
URL: https://github.com/apache/incubator-echarts/pull/11976
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org