[GitHub] [spark] zhengruifeng commented on a diff in pull request #41013: [SPARK-43509][CONNECT] Support Creating multiple Spark Connect sessions

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #41013:
URL: https://github.com/apache/spark/pull/41013#discussion_r1194572360


##########
python/pyspark/sql/utils.py:
##########
@@ -144,7 +144,7 @@ def is_remote() -> bool:
     """
     Returns if the current running environment is for Spark Connect.
     """
-    return "SPARK_REMOTE" in os.environ
+    return "SPARK_ENABLE_CONNECT_MODE" in os.environ

Review Comment:
   IIRC, we will drop the usage of `is_remote` ?  @HyukjinKwon 



##########
python/pyspark/context.py:
##########
@@ -180,7 +180,7 @@ def __init__(
         udf_profiler_cls: Type[UDFBasicProfiler] = UDFBasicProfiler,
         memory_profiler_cls: Type[MemoryProfiler] = MemoryProfiler,
     ):
-        if "SPARK_REMOTE" in os.environ and "SPARK_LOCAL_REMOTE" not in os.environ:

Review Comment:
   what is the difference between `SPARK_REMOTE` and `SPARK_ENABLE_CONNECT_MODE ` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org