You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2018/05/02 10:34:50 UTC
Review Request 66904: Added 'Ninja' byproducts for jemalloc.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66904/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Benno Evers.
Bugs: MESOS-8866
https://issues.apache.org/jira/browse/MESOS-8866
Repository: mesos
Description
-------
When building with 'Ninja', byproducts are used to resolve dependencies.
These have to be added for third-party dependencies.
Diffs
-----
3rdparty/CMakeLists.txt b7362d2be75e4de06092f16698a784b7a78994cb
Diff: https://reviews.apache.org/r/66904/diff/1/
Testing
-------
Ran
```
mkdir build && cd build &&
cmake -G Ninja -D ENABLE_JEMALLOC_ALLOCATOR=ON &&
ninja
```
and checked that `jemalloc` third-party dependency is build.
Thanks,
Jan Schlicht
Re: Review Request 66904: Added 'Ninja' byproducts for jemalloc.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66904/#review202267
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On May 2, 2018, 12:34 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66904/
> -----------------------------------------------------------
>
> (Updated May 2, 2018, 12:34 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benno Evers.
>
>
> Bugs: MESOS-8866
> https://issues.apache.org/jira/browse/MESOS-8866
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When building with 'Ninja', byproducts are used to resolve dependencies.
> These have to be added for third-party dependencies.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt b7362d2be75e4de06092f16698a784b7a78994cb
>
>
> Diff: https://reviews.apache.org/r/66904/diff/1/
>
>
> Testing
> -------
>
> Ran
> ```
> mkdir build && cd build &&
> cmake -G Ninja -D ENABLE_JEMALLOC_ALLOCATOR=ON &&
> ninja
> ```
> and checked that `jemalloc` third-party dependency is build.
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 66904: Added 'Ninja' byproducts for jemalloc.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66904/#review202270
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66904']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66904
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66904/logs/mesos-tests-stdout.log):
```
[----------] 9 tests from Endpoint/SlaveEndpointTest (1045 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (72 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (842 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (867 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (829 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (858 ms total)
[----------] Global test environment tear-down
[==========] 970 tests from 95 test cases ran. (479124 ms total)
[ PASSED ] 968 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] ContentType/ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider/0, where GetParam() = application/x-protobuf
[ FAILED ] ContentType/ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider/1, where GetParam() = application/json
2 FAILED TESTS
YOU HAVE 216 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66904/logs/mesos-tests-stderr.log):
```
I0502 11:32:34.963011 2348 slave.cpp:3935] Shutting down framework 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-0000
I0502 11:32:34.963011 9988 master.I0502 11:32:34.786969 13620 exec.cpp:162] Version: 1.6.0
I0502 11:32:34.815955 8536 exec.cpp:236] Executor registered on agent 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-S0
I0502 11:32:34.819974 11564 executor.cpp:177] Received SUBSCRIBED event
I0502 11:32:34.825969 11564 executor.cpp:181] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0502 11:32:34.825969 11564 executor.cpp:177] Received LAUNCH event
I0502 11:32:34.830970 11564 executor.cpp:649] Starting task 24f72e10-8771-4a91-a203-aab33e872eb9
I0502 11:32:34.919971 11564 executor.cpp:484] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0502 11:32:34.934976 11564 executor.cpp:662] Forked command at 5460
I0502 11:32:34.965945 13740 exec.cpp:445] Executor asked to shutdown
I0502 11:32:34.965945 14320 executor.cpp:177] Received SHUTDOWN event
I0502 11:32:34.965945 14320 executor.cpp:759] Shutting down
I0502 11:32:34.965945 14320 executor.cpp:869] Sending SIGTERM to process tree at pid 5cpp:10547] Updating the state of task 24f72e10-8771-4a91-a203-aab33e872eb9 of framework 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0502 11:32:34.963011 2348 slave.cpp:6644] Shutting down executor '24f72e10-8771-4a91-a203-aab33e872eb9' of framework 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-0000 at executor(1)@10.3.1.8:63219
I0502 11:32:34.964944 2348 slave.cpp:929] Agent terminating
W0502 11:32:34.965945 2348 slave.cpp:3931] Ignoring shutdown framework 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-0000 because it is terminating
I0502 11:32:34.966945 9988 master.cpp:10646] Removing task 24f72e10-8771-4a91-a203-aab33e872eb9 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-0000 on agent 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-S0 at slave(438)@10.3.1.8:63198 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0502 11:32:34.969947 9988 master.cpp:1296] Agent 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-S0 at slave(438)@10.3.1.8:63198 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0502 11:32:34.970940 14112 hierarchical.cpp:344] Removed framework 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-0000
I0502 11:32:34.970940 9988 master.cpp:3296] Disconnecting agent 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-S0 at slave(438)@10.3.1.8:63198 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0502 11:32:34.970940 9988 master.cpp:3315] Deactivating agent 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-S0 at slave(438)@10.3.1.8:63198 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0502 11:32:34.970940 9484 hierarchical.cpp:766] Agent 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-S0 deactivated
I0502 11:32:34.970940 4392 containerizer.cpp:2378] Destroying container 7729200a-9ca6-410c-bd17-8c934f8d7439 in RUNNING state
I0502 11:32:34.971948 4392 containerizer.cpp:2992] Transitioning the state of container 7729200a-9ca6-410c-bd17-8c934f8d7439 from RUNNING to DESTROYING
I0502 11:32:34.972978 4392 launcher.cpp:156] Asked to destroy container 7729200a-9ca6-410c-bd17-8c934f8d7439
I0502 11:32:35.077826 11404 containerizer.cpp:2831] Container 7729200a-9ca6-410c-bd17-8c934f8d7439 has exited
I0502 11:32:35.108829 10736 master.cpp:1138] Master terminating
I0502 11:32:35.111829 11792 hierarchical.cpp:609] Removed agent 3fdc910c-5ae2-49cf-a6ea-7d7ea90d4fee-S0
I0502 11:32:35.534843 12772 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On May 2, 2018, 10:34 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66904/
> -----------------------------------------------------------
>
> (Updated May 2, 2018, 10:34 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benno Evers.
>
>
> Bugs: MESOS-8866
> https://issues.apache.org/jira/browse/MESOS-8866
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When building with 'Ninja', byproducts are used to resolve dependencies.
> These have to be added for third-party dependencies.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt b7362d2be75e4de06092f16698a784b7a78994cb
>
>
> Diff: https://reviews.apache.org/r/66904/diff/1/
>
>
> Testing
> -------
>
> Ran
> ```
> mkdir build && cd build &&
> cmake -G Ninja -D ENABLE_JEMALLOC_ALLOCATOR=ON &&
> ninja
> ```
> and checked that `jemalloc` third-party dependency is build.
>
>
> Thanks,
>
> Jan Schlicht
>
>