You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "imply-elliott (via GitHub)" <gi...@apache.org> on 2023/05/03 17:20:08 UTC

[GitHub] [druid] imply-elliott commented on a diff in pull request #14205: Add labels to k8s jobs for the PodTemplateTaskAdapter

imply-elliott commented on code in PR #14205:
URL: https://github.com/apache/druid/pull/14205#discussion_r1183995273


##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/DruidK8sConstants.java:
##########
@@ -36,7 +36,8 @@
   public static final String TASK_ID_ENV = "TASK_ID";
   public static final String JAVA_OPTS = "JAVA_OPTS";
   public static final String DRUID_HOST_ENV = "druid_host";
-  public static final String DRUID_HOSTNAME_ENV = "HOSTNAME";
+  public static final String DRUID_HOSTNAME_ENV = "HOSTNAME"

Review Comment:
   Did you mean to remove the semicolon here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org