[GitHub] [ozone] sadanand48 commented on a diff in pull request #4122: HDDS-7702. [snapshot] Add unit-testcases for Ozone fs createSnapshot

[GitBox <gi...@apache.org>]

sadanand48 commented on code in PR #4122:
URL: https://github.com/apache/ozone/pull/4122#discussion_r1072071786


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFsSnapshot.java:
##########
@@ -116,4 +118,190 @@ public void testCreateSnapshot() throws Exception {
       shell.close();
     }
   }
+
+  @Test
+  public void testCreateSnapshotDuplicateName() throws Exception {
+    String volume = "vol-" + RandomStringUtils.randomNumeric(5);
+    String bucket = "buc-" + RandomStringUtils.randomNumeric(5);
+    String key = "key-" + RandomStringUtils.randomNumeric(5);
+    String snapshotName = "snap-" + RandomStringUtils.randomNumeric(5);
+
+    String testVolBucket = OM_KEY_PREFIX + volume + OM_KEY_PREFIX + bucket;
+    String testKey = testVolBucket + OM_KEY_PREFIX + key;
+
+    OzoneFsShell shell = new OzoneFsShell(clientConf);
+    try {
+      // Create volume and bucket
+      int res = ToolRunner.run(shell,

Review Comment:
   Bucket/Volume and key creation are common to most of these tests. Can we create a common method for these?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org