You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/09 05:45:12 UTC
[GitHub] [pulsar] lhotari opened a new pull request #11599: [Broker] Remove RateLimiter constructors and replace with builder usage
lhotari opened a new pull request #11599:
URL: https://github.com/apache/pulsar/pull/11599
### Motivation
RateLimiter class has multiple constructors. A Lombok builder was added as part of PR #10384 since there was a need to have yet another constructor. Having a lot of different constructors on a class is prone to errors and makes the code hard to read.
### Modifications
This PR removes all public constructors from RateLimiter class and replaces the usages of constructors with the usage of the builder in existing code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #11599: [Broker] Remove RateLimiter constructors and replace with builder usage
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #11599:
URL: https://github.com/apache/pulsar/pull/11599#issuecomment-991505534
Cherry picked to `branch-2.7` because one of the lines it removes is longer than 120 characters. Now `branch-2.7` passes checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #11599: [Broker] Remove RateLimiter constructors and replace with builder usage
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #11599:
URL: https://github.com/apache/pulsar/pull/11599#issuecomment-991505534
Cherry picked to `branch-2.7` because one of the lines it removes is longer than 120 characters. Now `branch-2.7` passes checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #11599: [Broker] Remove RateLimiter constructors and replace with builder usage
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #11599:
URL: https://github.com/apache/pulsar/pull/11599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org