You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2013/02/19 16:27:14 UTC
[jira] [Updated] (SSHD-202) SSH Client silently accepts server key
by default :-(
[ https://issues.apache.org/jira/browse/SSHD-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated SSHD-202:
---------------------------------
Fix Version/s: 0.9.0
> SSH Client silently accepts server key by default :-(
> -----------------------------------------------------
>
> Key: SSHD-202
> URL: https://issues.apache.org/jira/browse/SSHD-202
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 0.8.0
> Environment: Windows
> Reporter: Andrew C
> Assignee: Guillaume Nodet
> Fix For: 0.9.0
>
> Attachments: sshd-202.patch
>
>
> The default SshClient, returned by SshClient.setUpDefaultClient, silently accepts the server's public key. This is because ClientSessionImpl.checkHost allows a null ServerKeyVerifier and silently succeeds, This is, IMNSHO, really bad. Instead, I'd suggest:
> - SshClient.checkConfig require a ServerKeyVerifier
> - ClientSessionImpl.checkHost crash and burn when ServerKeyVerifier is null
> - SshClient.setupDefaultClient set it to AcceptAllServerKeyVerifier (maintains compatibility)
> - and AcceptAllServerKeyVerifier clearly log its action at the warning, not trace level
> Tweaking RequiredServerKeyVerifier to log its actions would also be helpful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira