You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Yongjun Zhang (JIRA)" <ji...@apache.org> on 2014/11/11 01:07:34 UTC

[jira] [Commented] (HADOOP-11293) Factor OSType out from Shell

    [ https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205612#comment-14205612 ] 

Yongjun Zhang commented on HADOOP-11293:
----------------------------------------

Submitted patch rev 001. This is a massive change that touches a lot of files, but I think it would make the code a cleaner.

Hi [~cmccabe], thanks for your encouragement when I told you that I found making a change like this would be nice. So I went ahead and made the changes. Would you please help taking a look at the patch when you have time? thanks.



> Factor OSType out from Shell
> ----------------------------
>
>                 Key: HADOOP-11293
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11293
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-11293.001.patch
>
>
> Currently the code that detects the OS type is located in Shell.java. Code that need to check OS type refers to Shell, even if no other stuff of Shell is needed. 
> I am proposing to refactor OSType out to  its own class, so to make the OSType easier to access and the dependency cleaner.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)