You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "hangc0276 (via GitHub)" <gi...@apache.org> on 2023/03/10 08:28:17 UTC

[GitHub] [bookkeeper] hangc0276 opened a new pull request, #3854: Disable trimStackTrack for code-coverage profile

hangc0276 opened a new pull request, #3854:
URL: https://github.com/apache/bookkeeper/pull/3854

   ### Motivation
   We run unit tests in CI based on the `code-coverage` profile, and it enabled the trimStackTrack by default, which trimmed the stack for some failed tests.
   
   ### Modifications
   Disable `trimStackTrack` for the `code-coverage` profile.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] merlimat merged pull request #3854: Disable trimStackTrack for code-coverage profile

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3854:
URL: https://github.com/apache/bookkeeper/pull/3854


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] codecov-commenter commented on pull request #3854: Disable trimStackTrack for code-coverage profile

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3854:
URL: https://github.com/apache/bookkeeper/pull/3854#issuecomment-1463476133

   ## [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3854?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3854](https://codecov.io/gh/apache/bookkeeper/pull/3854?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a015ced) into [master](https://codecov.io/gh/apache/bookkeeper/commit/caddb6ee5bbf1823dfa6cae6cb419159f7327aa6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (caddb6e) will **decrease** coverage by `39.45%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3854       +/-   ##
   =============================================
   - Coverage     60.42%   20.97%   -39.45%     
   + Complexity     5862     2017     -3845     
   =============================================
     Files           473      473               
     Lines         40982    40982               
     Branches       5241     5241               
   =============================================
   - Hits          24762     8595    -16167     
   - Misses        14002    31123    +17121     
   + Partials       2218     1264      -954     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | bookie | `?` | |
   | remaining | `?` | |
   | replication | `?` | |
   | tls | `20.97% <ø> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 349 files with indirect coverage changes](https://codecov.io/gh/apache/bookkeeper/pull/3854/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org