You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "onichols-pivotal (GitHub)" <gi...@apache.org> on 2018/12/21 18:41:08 UTC
[GitHub] [geode] onichols-pivotal opened pull request #3033:
GEODE-6236 fix inconsistent handling of versionNumber
In a few build scripts versionNumber was obtained by parsing gradle.properties directly. This approach gave incorrect value if that property had been overridden with a -P on the gradle command line.
Now the overrides are considered before the properties file, mimicking the value gradle would choose in all cases.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [n/a] Does `gradlew build` run cleanly?
- [n/a] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3033 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dickcav closed pull request #3033: GEODE-6236 fix
inconsistent handling of versionNumber
Posted by "dickcav (GitHub)" <gi...@apache.org>.
[ pull request closed by dickcav ]
[ Full content available at: https://github.com/apache/geode/pull/3033 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org