You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/02/01 19:54:19 UTC
[GitHub] [nifi] markap14 commented on a change in pull request #5712: NIFI-9628: Added a uiOnly flag when requesting Controller Service det…
markap14 commented on a change in pull request #5712:
URL: https://github.com/apache/nifi/pull/5712#discussion_r796949556
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/SnippetUtils.java
##########
@@ -1015,4 +1018,33 @@ private void normalizeCoordinates(Collection<? extends ComponentDTO> components)
}
}
+ public static void stripNonUiRelevantFields(final ControllerServiceEntity serviceEntity) {
Review comment:
It's referenced from a few different places. So I wanted to extract the logic into some sort of utility class that could be easily referenced from all of the resources that needed it. We could create a separate util class - `ControllerServiceUtils` or something like that maybe? Didn't feel like that warranted its own util class, and i figured one could argue that this deals with a snippet of the flow. Though I suppose this util class is actually intended for interacting with Snippets with a capital S, the specific components. I could move it into its own util class if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org