You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/10 20:13:19 UTC
[GitHub] [incubator-superset] SWoto opened a new issue #8913: Issue with Currency format D3
SWoto opened a new issue #8913:
URL: https://github.com/apache/incubator-superset/issues/8913
I'm trying to set up the currency format in superset charts but it is always displayed in the American format. ($ 1,234.56)
Tried the solution present in #3972 by @PeterCahn by changing the superset/assets/node_modules/d3-format/src/defaultLocale.js file to the desired one and didn't work for the currency problem.
```
decimal: ",",
thousands: ".",
grouping: [3],
currency: ["R$", ""],
dateTime: "%d/%m/%Y %H:%M:%S",
date: "%d/%m/%Y",
time: "%H:%M:%S",
periods: ["AM", "PM"],
days: ["Domingo", "Segunda", "Terça", "Quarta", "Quinta", "Sexta", "Sábado"],
shortDays: ["Dom", "Seg", "Ter", "Qua", "Qui", "Sex", "Sáb"],
months: ["Janeiro", "Fevereiro", "Março", "Abril", "Maio", "Junho", "Julho", "Agosto", "Setembro", "Outubro", "Novembro", "Dezembro"],
shortMonths: ["Jan", "Fev", "Mar", "Abr", "Mai", "Jun", "Jul", "Ago", "Set", "Out", "Nov", "Dez"]});
```
### Expected results
Expected to see the currency as R$ 1.234,56
### Actual results
$ 1,234.56
#### Screenshots
I highlighted the date because looks like the defaultLocale is working for date/time.
<img width="1405" alt="Foto" src="https://user-images.githubusercontent.com/26379593/71686032-d4ef4f00-2d78-11ea-9340-7f65233b2d25.png">
### Environment
(please complete the following information):
- superset version: `0.34.1rc1`
- python version: `Python 3.6.9`
- node.js version: `v10.16.3`
- npm version: `6.9.0`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
I'm opening this new issue because the previus one was closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] SWoto commented on issue #8913: Issue with Currency format D3
Posted by GitBox <gi...@apache.org>.
SWoto commented on issue #8913:
URL: https://github.com/apache/incubator-superset/issues/8913#issuecomment-690797069
@osandrolucas,
I've tried some things but to no avail. The best solution at that time was use a query to change the currency to text and replace the points with commas.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] osandrolucas commented on issue #8913: Issue with Currency format D3
Posted by GitBox <gi...@apache.org>.
osandrolucas commented on issue #8913:
URL: https://github.com/apache/incubator-superset/issues/8913#issuecomment-691202595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc closed issue #8913: Issue with Currency format D3
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #8913:
URL: https://github.com/apache/incubator-superset/issues/8913
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] osandrolucas commented on issue #8913: Issue with Currency format D3
Posted by GitBox <gi...@apache.org>.
osandrolucas commented on issue #8913:
URL: https://github.com/apache/incubator-superset/issues/8913#issuecomment-691202595
Ok :(
Thanks for the support @SWoto
**I have an suggestion:**
concat('R$ ', format('%,.2f', value))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #8913: Issue with Currency format D3
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #8913:
URL: https://github.com/apache/incubator-superset/issues/8913#issuecomment-693947861
I recently answered a fairly similar question over on Stack Overflow, which points to some of the code that can be edited to create currency locales with custom currency symbols and separator (decimal/comma) placement/formatting.
https://stackoverflow.com/questions/63319902/customise-the-number-format-in-apache-superset/63385549#63385549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] SWoto edited a comment on issue #8913: Issue with Currency format D3
Posted by GitBox <gi...@apache.org>.
SWoto edited a comment on issue #8913:
URL: https://github.com/apache/incubator-superset/issues/8913#issuecomment-690797069
@osandrolucas,
Changing d3 format made some differences, but most of the problem persisted.
I've tried some things but to no avail. The best solution at that time was use a query to change the currency to text and replace the points with commas.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] osandrolucas commented on issue #8913: Issue with Currency format D3
Posted by GitBox <gi...@apache.org>.
osandrolucas commented on issue #8913:
URL: https://github.com/apache/incubator-superset/issues/8913#issuecomment-694409218
Great!
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] osandrolucas commented on issue #8913: Issue with Currency format D3
Posted by GitBox <gi...@apache.org>.
osandrolucas commented on issue #8913:
URL: https://github.com/apache/incubator-superset/issues/8913#issuecomment-690684030
Hi.
I have the same problem. How to fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] osandrolucas commented on issue #8913: Issue with Currency format D3
Posted by GitBox <gi...@apache.org>.
osandrolucas commented on issue #8913:
URL: https://github.com/apache/incubator-superset/issues/8913#issuecomment-691202595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org