You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/19 08:59:07 UTC
[GitHub] [flink] liyubin117 opened a new pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
liyubin117 opened a new pull request #17517:
URL: https://github.com/apache/flink/pull/17517
## What is the purpose of the change
make compacting process logs more usable, print the change in the size of the compacted files
## Brief change log
* get blocksize of files when output log of compacting files
## Verifying this change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17517:
URL: https://github.com/apache/flink/pull/17517#issuecomment-946506933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208",
"triggerID" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"triggerType" : "PUSH"
}, {
"hash" : "8422564faa92854edef71ae5493407d5313d9999",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25212",
"triggerID" : "8422564faa92854edef71ae5493407d5313d9999",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8422564faa92854edef71ae5493407d5313d9999 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25212)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17517:
URL: https://github.com/apache/flink/pull/17517#issuecomment-946506933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208",
"triggerID" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"triggerType" : "PUSH"
}, {
"hash" : "8422564faa92854edef71ae5493407d5313d9999",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25212",
"triggerID" : "8422564faa92854edef71ae5493407d5313d9999",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff513e0ff36012d4c2a0c995e14c9dd7228cc345 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208)
* 8422564faa92854edef71ae5493407d5313d9999 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25212)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liyubin117 commented on a change in pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
liyubin117 commented on a change in pull request #17517:
URL: https://github.com/apache/flink/pull/17517#discussion_r731679653
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/stream/compact/CompactOperator.java
##########
@@ -198,6 +198,11 @@ private void doCompact(String partition, List<Path> paths) throws IOException {
return;
}
+ List<Long> pathsSize = new ArrayList<>();
+ for (Path path : paths) {
+ pathsSize.add(fileSystem.getFileStatus(path).getBlockSize());
Review comment:
yeah, CompactCoordinator use getLen() too, i will use this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17517:
URL: https://github.com/apache/flink/pull/17517#issuecomment-946506933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208",
"triggerID" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"triggerType" : "PUSH"
}, {
"hash" : "209a79b7fa82bf58c33853100bc4383a095b1b7c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "209a79b7fa82bf58c33853100bc4383a095b1b7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff513e0ff36012d4c2a0c995e14c9dd7228cc345 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208)
* 209a79b7fa82bf58c33853100bc4383a095b1b7c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17517:
URL: https://github.com/apache/flink/pull/17517#issuecomment-946506933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208",
"triggerID" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"triggerType" : "PUSH"
}, {
"hash" : "8422564faa92854edef71ae5493407d5313d9999",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8422564faa92854edef71ae5493407d5313d9999",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff513e0ff36012d4c2a0c995e14c9dd7228cc345 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208)
* 8422564faa92854edef71ae5493407d5313d9999 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17517:
URL: https://github.com/apache/flink/pull/17517#issuecomment-946506933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff513e0ff36012d4c2a0c995e14c9dd7228cc345 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17517:
URL: https://github.com/apache/flink/pull/17517#issuecomment-946508883
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ff513e0ff36012d4c2a0c995e14c9dd7228cc345 (Tue Oct 19 09:02:43 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #17517:
URL: https://github.com/apache/flink/pull/17517#discussion_r731663969
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/stream/compact/CompactOperator.java
##########
@@ -198,6 +198,11 @@ private void doCompact(String partition, List<Path> paths) throws IOException {
return;
}
+ List<Long> pathsSize = new ArrayList<>();
+ for (Path path : paths) {
+ pathsSize.add(fileSystem.getFileStatus(path).getBlockSize());
Review comment:
use getLen?
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/stream/compact/CompactOperator.java
##########
@@ -217,12 +222,17 @@ private void doCompact(String partition, List<Path> paths) throws IOException {
doMultiFilesCompact(partition, paths, target);
}
+ long targetSize = fileSystem.getFileStatus(target).getBlockSize();
+
double costSeconds = ((double) (System.currentTimeMillis() - startMillis)) / 1000;
LOG.info(
- "Compaction time cost is '{}S', target file is '{}', input files are '{}'",
+ "Compaction time cost is '{}S', target file={name: '{}', size(byte): {}}, "
+ + "input files={name: '{}', size(byte): {}}",
Review comment:
Can we collect name and size to a HashMap, and just print it? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #17517:
URL: https://github.com/apache/flink/pull/17517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liyubin117 commented on a change in pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
liyubin117 commented on a change in pull request #17517:
URL: https://github.com/apache/flink/pull/17517#discussion_r731712722
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/stream/compact/CompactOperator.java
##########
@@ -217,12 +222,17 @@ private void doCompact(String partition, List<Path> paths) throws IOException {
doMultiFilesCompact(partition, paths, target);
}
+ long targetSize = fileSystem.getFileStatus(target).getBlockSize();
+
double costSeconds = ((double) (System.currentTimeMillis() - startMillis)) / 1000;
LOG.info(
- "Compaction time cost is '{}S', target file is '{}', input files are '{}'",
+ "Compaction time cost is '{}S', target file={name: '{}', size(byte): {}}, "
+ + "input files={name: '{}', size(byte): {}}",
Review comment:
excellent idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17517:
URL: https://github.com/apache/flink/pull/17517#issuecomment-946506933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208",
"triggerID" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"triggerType" : "PUSH"
}, {
"hash" : "8422564faa92854edef71ae5493407d5313d9999",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25212",
"triggerID" : "8422564faa92854edef71ae5493407d5313d9999",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff513e0ff36012d4c2a0c995e14c9dd7228cc345 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208)
* 8422564faa92854edef71ae5493407d5313d9999 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25212)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17517: [FLINK-24585][filesystem] Print the change in the size of the compacted files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17517:
URL: https://github.com/apache/flink/pull/17517#issuecomment-946506933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208",
"triggerID" : "ff513e0ff36012d4c2a0c995e14c9dd7228cc345",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff513e0ff36012d4c2a0c995e14c9dd7228cc345 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org