You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/11/27 16:13:37 UTC

[commons-vfs] branch master updated (bca592a -> 7c5cf5d)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git.


    from bca592a  Fix Checkstyle RedundantModifier: Redundant 'public' modifier.
     new 65d0fc9  Fix Checkstyle WhitespaceAround: 'synchronized' is not followed by whitespace.
     new 7c5cf5d  Fix Checkstyle NoWhitespaceAfter: '{' is followed by whitespace.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../org/apache/commons/vfs2/FileSystemException.java  |  4 ++--
 .../apache/commons/vfs2/cache/SoftRefFilesCache.java  |  4 ++--
 .../commons/vfs2/filter/WildcardFileFilter.java       |  4 ++--
 .../commons/vfs2/impl/DefaultFileReplicator.java      |  3 +--
 .../commons/vfs2/impl/DefaultFileSystemManager.java   |  4 ++--
 .../org/apache/commons/vfs2/impl/VFSClassLoader.java  |  4 ++--
 .../commons/vfs2/provider/AbstractFileName.java       |  2 +-
 .../org/apache/commons/vfs2/provider/UriParser.java   |  6 ++----
 .../provider/compressed/CompressedFileFileObject.java |  2 +-
 .../vfs2/provider/http4/Http4FileProvider.java        |  3 +--
 .../vfs2/provider/http5/Http5FileProvider.java        |  3 +--
 .../vfs2/provider/local/LocalFileNameParser.java      |  2 +-
 .../commons/vfs2/provider/tar/Tbz2FileProvider.java   |  2 +-
 .../commons/vfs2/provider/tar/TgzFileProvider.java    |  2 +-
 .../org/apache/commons/vfs2/util/DefaultCryptor.java  |  6 ++----
 .../vfs2/util/DelegatingFileSystemOptionsBuilder.java | 19 ++++++++-----------
 .../java/org/apache/commons/vfs2/util/Messages.java   |  2 +-
 .../main/java/org/apache/commons/vfs2/util/Os.java    | 13 ++++++-------
 18 files changed, 37 insertions(+), 48 deletions(-)

[commons-vfs] 01/02: Fix Checkstyle WhitespaceAround: 'synchronized' is not followed by whitespace.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git

commit 65d0fc941e2e8f03e059f95586e2e95c8d588e54
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Nov 27 11:01:07 2021 -0500

    Fix Checkstyle WhitespaceAround: 'synchronized' is not followed by
    whitespace.
---
 .../main/java/org/apache/commons/vfs2/cache/SoftRefFilesCache.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/cache/SoftRefFilesCache.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/cache/SoftRefFilesCache.java
index 1b283ba..78a4705 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/cache/SoftRefFilesCache.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/cache/SoftRefFilesCache.java
@@ -164,7 +164,7 @@ public class SoftRefFilesCache extends AbstractFilesCache {
             log.debug("putFile: " + this.getSafeName(fileObject));
         }
 
-        synchronized(this) {
+        synchronized (this) {
             final Map<FileName, Reference<FileObject>> files = getOrCreateFilesystemCache(fileObject.getFileSystem());
 
             final Reference<FileObject> ref = createReference(fileObject, refQueue);
@@ -184,7 +184,7 @@ public class SoftRefFilesCache extends AbstractFilesCache {
             log.debug("putFile: " + this.getSafeName(fileObject));
         }
 
-        synchronized(this) {
+        synchronized (this) {
             final Map<FileName, Reference<FileObject>> files = getOrCreateFilesystemCache(fileObject.getFileSystem());
 
             final Reference<FileObject> ref = createReference(fileObject, refQueue);

[commons-vfs] 02/02: Fix Checkstyle NoWhitespaceAfter: '{' is followed by whitespace.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git

commit 7c5cf5d036e5c1201e1d32e0cb94e5c00ddfb36f
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Nov 27 11:13:34 2021 -0500

    Fix Checkstyle NoWhitespaceAfter: '{' is followed by whitespace.
---
 .../org/apache/commons/vfs2/FileSystemException.java  |  4 ++--
 .../commons/vfs2/filter/WildcardFileFilter.java       |  4 ++--
 .../commons/vfs2/impl/DefaultFileReplicator.java      |  3 +--
 .../commons/vfs2/impl/DefaultFileSystemManager.java   |  4 ++--
 .../org/apache/commons/vfs2/impl/VFSClassLoader.java  |  4 ++--
 .../commons/vfs2/provider/AbstractFileName.java       |  2 +-
 .../org/apache/commons/vfs2/provider/UriParser.java   |  6 ++----
 .../provider/compressed/CompressedFileFileObject.java |  2 +-
 .../vfs2/provider/http4/Http4FileProvider.java        |  3 +--
 .../vfs2/provider/http5/Http5FileProvider.java        |  3 +--
 .../vfs2/provider/local/LocalFileNameParser.java      |  2 +-
 .../commons/vfs2/provider/tar/Tbz2FileProvider.java   |  2 +-
 .../commons/vfs2/provider/tar/TgzFileProvider.java    |  2 +-
 .../org/apache/commons/vfs2/util/DefaultCryptor.java  |  6 ++----
 .../vfs2/util/DelegatingFileSystemOptionsBuilder.java | 19 ++++++++-----------
 .../java/org/apache/commons/vfs2/util/Messages.java   |  2 +-
 .../main/java/org/apache/commons/vfs2/util/Os.java    | 13 ++++++-------
 17 files changed, 35 insertions(+), 46 deletions(-)

diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileSystemException.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileSystemException.java
index 69fa8d1..8422022 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileSystemException.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileSystemException.java
@@ -106,7 +106,7 @@ public class FileSystemException extends IOException {
      * @param info one context information.
      */
     public FileSystemException(final String code, final Object info) {
-        this(code, null, new Object[] { info });
+        this(code, null, new Object[] {info});
     }
 
     /**
@@ -117,7 +117,7 @@ public class FileSystemException extends IOException {
      * @param cause the cause.
      */
     public FileSystemException(final String code, final Object info, final Throwable cause) {
-        this(code, cause, new Object[] { info });
+        this(code, cause, new Object[] {info});
     }
 
     /**
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/filter/WildcardFileFilter.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/filter/WildcardFileFilter.java
index f290e36..7d85df4 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/filter/WildcardFileFilter.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/filter/WildcardFileFilter.java
@@ -173,7 +173,7 @@ public class WildcardFileFilter implements FileFilter, Serializable {
         // package level so a unit test may run on this
 
         if (text.indexOf('?') == -1 && text.indexOf('*') == -1) {
-            return new String[] { text };
+            return new String[] {text};
         }
 
         final char[] array = text.toCharArray();
@@ -274,7 +274,7 @@ public class WildcardFileFilter implements FileFilter, Serializable {
                         }
                         final int repeat = caseSensitivity.checkIndexOf(fileName, textIdx + 1, wcs[wcsIdx]);
                         if (repeat >= 0) {
-                            backtrack.push(new int[] { wcsIdx, repeat });
+                            backtrack.push(new int[] {wcsIdx, repeat});
                         }
                     } else if (!caseSensitivity.checkRegionMatches(fileName, textIdx, wcs[wcsIdx])) {
                         // matching from current position
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/DefaultFileReplicator.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/DefaultFileReplicator.java
index e297d5b..35b0e47 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/DefaultFileReplicator.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/DefaultFileReplicator.java
@@ -41,8 +41,7 @@ public class DefaultFileReplicator extends AbstractVfsComponent implements FileR
 
     private static final Random random = new Random();
 
-    private static final char[] TMP_RESERVED_CHARS = { '?', '/', '\\', ' ', '&', '"', '\'', '*', '#', ';',
-            ':', '<', '>', '|' };
+    private static final char[] TMP_RESERVED_CHARS = {'?', '/', '\\', ' ', '&', '"', '\'', '*', '#', ';', ':', '<', '>', '|'};
 
     private final ArrayList<Object> copies = new ArrayList<>();
     private long filecount;
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/DefaultFileSystemManager.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/DefaultFileSystemManager.java
index 3798867..613a5d0 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/DefaultFileSystemManager.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/DefaultFileSystemManager.java
@@ -224,7 +224,7 @@ public class DefaultFileSystemManager implements FileSystemManager {
     @Override
     public void addOperationProvider(final String scheme, final FileOperationProvider operationProvider)
             throws FileSystemException {
-        addOperationProvider(new String[] { scheme }, operationProvider);
+        addOperationProvider(new String[] {scheme}, operationProvider);
     }
 
     /**
@@ -267,7 +267,7 @@ public class DefaultFileSystemManager implements FileSystemManager {
      * @throws FileSystemException if an error occurs adding the provider.
      */
     public void addProvider(final String urlScheme, final FileProvider provider) throws FileSystemException {
-        addProvider(new String[] { urlScheme }, provider);
+        addProvider(new String[] {urlScheme}, provider);
     }
 
     /**
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/VFSClassLoader.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/VFSClassLoader.java
index 885a496..3ab96f7 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/VFSClassLoader.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/VFSClassLoader.java
@@ -60,7 +60,7 @@ public class VFSClassLoader extends SecureClassLoader {
      * @throws FileSystemException if an error occurs.
      */
     public VFSClassLoader(final FileObject file, final FileSystemManager manager) throws FileSystemException {
-        this(new FileObject[] { file }, manager, null);
+        this(new FileObject[] {file}, manager, null);
     }
 
     /**
@@ -73,7 +73,7 @@ public class VFSClassLoader extends SecureClassLoader {
      */
     public VFSClassLoader(final FileObject file, final FileSystemManager manager, final ClassLoader parent)
             throws FileSystemException {
-        this(new FileObject[] { file }, manager, parent);
+        this(new FileObject[] {file}, manager, parent);
     }
 
     /**
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
index 0d4a01a..daafa83 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
@@ -40,7 +40,7 @@ public abstract class AbstractFileName implements FileName {
     // Since : and / occur before the path, only chars after path are escaped (i.e., # and ?)
     // ? is a reserved filesystem character for Windows and Unix, so can't be part of a file name.
     // Therefore only # is a reserved char in a URI as part of the path that can be in the file name.
-    private static final char[] RESERVED_URI_CHARS = { '#', ' ' };
+    private static final char[] RESERVED_URI_CHARS = {'#', ' '};
 
     private final String scheme;
     private final String absPath;
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/UriParser.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/UriParser.java
index a8f5ffb..66a56c4 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/UriParser.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/UriParser.java
@@ -102,8 +102,7 @@ public final class UriParser {
                 count -= 2;
             } else if (fileNameParser.encodeCharacter(ch)) {
                 // Encode
-                final char[] digits = { Character.forDigit(ch >> BITS_IN_HALF_BYTE & LOW_MASK, HEX_BASE),
-                        Character.forDigit(ch & LOW_MASK, HEX_BASE) };
+                final char[] digits = {Character.forDigit(ch >> BITS_IN_HALF_BYTE & LOW_MASK, HEX_BASE), Character.forDigit(ch & LOW_MASK, HEX_BASE)};
                 buffer.setCharAt(index, '%');
                 buffer.insert(index + 1, digits);
                 index += 2;
@@ -244,8 +243,7 @@ public final class UriParser {
             }
             if (match) {
                 // Encode
-                final char[] digits = { Character.forDigit(ch >> BITS_IN_HALF_BYTE & LOW_MASK, HEX_BASE),
-                        Character.forDigit(ch & LOW_MASK, HEX_BASE) };
+                final char[] digits = {Character.forDigit(ch >> BITS_IN_HALF_BYTE & LOW_MASK, HEX_BASE), Character.forDigit(ch & LOW_MASK, HEX_BASE)};
                 buffer.setCharAt(index, '%');
                 buffer.insert(index + 1, digits);
                 index += 2;
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/compressed/CompressedFileFileObject.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/compressed/CompressedFileFileObject.java
index 340d983..77861f3 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/compressed/CompressedFileFileObject.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/compressed/CompressedFileFileObject.java
@@ -53,7 +53,7 @@ public abstract class CompressedFileFileObject<FS extends CompressedFileFileSyst
         if (pos > 0) {
             basename = basename.substring(0, pos);
         }
-        children = new String[] { basename };
+        children = new String[] {basename};
     }
 
     /**
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http4/Http4FileProvider.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http4/Http4FileProvider.java
index fa043b8..ca8cc5d 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http4/Http4FileProvider.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http4/Http4FileProvider.java
@@ -255,8 +255,7 @@ public class Http4FileProvider extends AbstractOriginatingFileProvider {
 
             if (proxyAuth != null) {
                 final UserAuthenticationData proxyAuthData = UserAuthenticatorUtils.authenticate(proxyAuth,
-                        new UserAuthenticationData.Type[] { UserAuthenticationData.USERNAME,
-                                UserAuthenticationData.PASSWORD });
+                    new UserAuthenticationData.Type[] {UserAuthenticationData.USERNAME, UserAuthenticationData.PASSWORD});
 
                 if (proxyAuthData != null) {
                     final UsernamePasswordCredentials proxyCreds = new UsernamePasswordCredentials(
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/Http5FileProvider.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/Http5FileProvider.java
index 0602fcb..8be9dd8 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/Http5FileProvider.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/Http5FileProvider.java
@@ -251,8 +251,7 @@ public class Http5FileProvider extends AbstractOriginatingFileProvider {
 
             if (proxyAuth != null) {
                 final UserAuthenticationData proxyAuthData = UserAuthenticatorUtils.authenticate(proxyAuth,
-                        new UserAuthenticationData.Type[] { UserAuthenticationData.USERNAME,
-                                UserAuthenticationData.PASSWORD });
+                    new UserAuthenticationData.Type[] {UserAuthenticationData.USERNAME, UserAuthenticationData.PASSWORD});
 
                 if (proxyAuthData != null) {
                     final UsernamePasswordCredentials proxyCreds = new UsernamePasswordCredentials(
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileNameParser.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileNameParser.java
index 4b5de23..bdb67dc 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileNameParser.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileNameParser.java
@@ -44,7 +44,7 @@ public abstract class LocalFileNameParser extends AbstractFileNameParser {
 
     private String[] getSchemes(final VfsComponentContext context, final FileName base, final String uri) {
         if (context == null) {
-            return new String[] { base != null ? base.getScheme() : URI.create(uri).getScheme() };
+            return new String[] {base != null ? base.getScheme() : URI.create(uri).getScheme()};
         }
         return context.getFileSystemManager().getSchemes();
     }
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/Tbz2FileProvider.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/Tbz2FileProvider.java
index bd95861..3074c08 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/Tbz2FileProvider.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/Tbz2FileProvider.java
@@ -29,7 +29,7 @@ public class Tbz2FileProvider extends CompositeFileProvider {
     /** The provider's capabilities */
     protected static final Collection<Capability> capabilities = TarFileProvider.capabilities;
 
-    private static final String[] SCHEMES = { "bz2", "tar" };
+    private static final String[] SCHEMES = {"bz2", "tar"};
 
     public Tbz2FileProvider() {
     }
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/TgzFileProvider.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/TgzFileProvider.java
index 36649a0..a526b8b 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/TgzFileProvider.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/TgzFileProvider.java
@@ -29,7 +29,7 @@ public class TgzFileProvider extends CompositeFileProvider {
     /** The provider's capabilities */
     protected static final Collection<Capability> capabilities = TarFileProvider.capabilities;
 
-    private static final String[] SCHEMES = { "gz", "tar" };
+    private static final String[] SCHEMES = {"gz", "tar"};
 
     public TgzFileProvider() {
     }
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DefaultCryptor.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DefaultCryptor.java
index 53d9005..7036b61 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DefaultCryptor.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DefaultCryptor.java
@@ -31,11 +31,9 @@ import javax.crypto.spec.SecretKeySpec;
  * @since 2.0
  */
 public class DefaultCryptor implements Cryptor {
-    private static final char[] HEX_CHARS = { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E',
-            'F' };
+    private static final char[] HEX_CHARS = {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F'};
 
-    private static final byte[] KEY_BYTES = { 0x41, 0x70, 0x61, 0x63, 0x68, 0x65, 0x43, 0x6F, 0x6D, 0x6D, 0x6F, 0x6E,
-            0x73, 0x56, 0x46, 0x53 };
+    private static final byte[] KEY_BYTES = {0x41, 0x70, 0x61, 0x63, 0x68, 0x65, 0x43, 0x6F, 0x6D, 0x6D, 0x6F, 0x6E, 0x73, 0x56, 0x46, 0x53};
 
     private static final int INDEX_NOT_FOUND = -1;
 
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DelegatingFileSystemOptionsBuilder.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DelegatingFileSystemOptionsBuilder.java
index 6905f8c..ffdea92 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DelegatingFileSystemOptionsBuilder.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DelegatingFileSystemOptionsBuilder.java
@@ -50,7 +50,7 @@ import org.apache.commons.vfs2.FileSystemOptions;
 public class DelegatingFileSystemOptionsBuilder {
 
     @SuppressWarnings("unchecked") // OK, it is a String
-    private static final Class<String>[] STRING_PARAM = new Class[] { String.class };
+    private static final Class<String>[] STRING_PARAM = new Class[] {String.class};
     private static final Map<String, Class<?>> PRIMATIVE_TO_OBJECT = new TreeMap<>();
     private static final Log log = LogFactory.getLog(DelegatingFileSystemOptionsBuilder.class);
 
@@ -116,7 +116,7 @@ public class DelegatingFileSystemOptionsBuilder {
      */
     public void setConfigString(final FileSystemOptions fso, final String scheme, final String name, final String value)
             throws FileSystemException {
-        setConfigStrings(fso, scheme, name, new String[] { value });
+        setConfigStrings(fso, scheme, name, new String[] {value});
     }
 
     /**
@@ -151,7 +151,7 @@ public class DelegatingFileSystemOptionsBuilder {
      */
     public void setConfigClass(final FileSystemOptions fso, final String scheme, final String name,
             final Class<?> className) throws FileSystemException, IllegalAccessException, InstantiationException {
-        setConfigClasses(fso, scheme, name, new Class[] { className });
+        setConfigClasses(fso, scheme, name, new Class[] {className});
     }
 
     /**
@@ -242,8 +242,7 @@ public class DelegatingFileSystemOptionsBuilder {
             return true;
         }
         if (valueClass != String.class) {
-            log.warn(Messages.getString("vfs.provider/config-unexpected-value-class.error", valueClass.getName(),
-                    ctx.scheme, ctx.name));
+            log.warn(Messages.getString("vfs.provider/config-unexpected-value-class.error", valueClass.getName(), ctx.scheme, ctx.name));
             return false;
         }
 
@@ -283,8 +282,7 @@ public class DelegatingFileSystemOptionsBuilder {
             // can convert using factory method (valueOf)
             for (int iterValues = 0; iterValues < ctx.values.length; iterValues++) {
                 try {
-                    Array.set(convertedValues, iterValues,
-                            valueFactory.invoke(null, ctx.values[iterValues]));
+                    Array.set(convertedValues, iterValues, valueFactory.invoke(null, ctx.values[iterValues]));
                 } catch (final IllegalAccessException | InvocationTargetException e) {
                     throw new FileSystemException(e);
                 }
@@ -300,13 +298,12 @@ public class DelegatingFileSystemOptionsBuilder {
     /**
      * Invokes the method with the converted values
      */
-    private void invokeSetter(final Class<?> valueParameter, final Context ctx, final Method configSetter,
-            final Object values) throws FileSystemException {
+    private void invokeSetter(final Class<?> valueParameter, final Context ctx, final Method configSetter, final Object values) throws FileSystemException {
         final Object[] args;
         if (valueParameter.isArray()) {
-            args = new Object[] { ctx.fso, values };
+            args = new Object[] {ctx.fso, values};
         } else {
-            args = new Object[] { ctx.fso, Array.get(values, 0) };
+            args = new Object[] {ctx.fso, Array.get(values, 0)};
         }
         try {
             configSetter.invoke(ctx.fileSystemConfigBuilder, args);
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/Messages.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/Messages.java
index b2f922d..da1be1e 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/Messages.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/Messages.java
@@ -64,7 +64,7 @@ public final class Messages {
      */
     @Deprecated
     public static String getString(final String code, final Object param) {
-        return getString(code, new Object[] { param });
+        return getString(code, new Object[] {param});
     }
 
     /**
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/Os.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/Os.java
index 5168b50..9ef9cdf 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/Os.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/Os.java
@@ -47,18 +47,17 @@ public final class Os {
     /**
      * All Windows NT based OSes.
      */
-    public static final OsFamily OS_FAMILY_WINNT = new OsFamily("nt", new OsFamily[] { OS_FAMILY_WINDOWS });
+    public static final OsFamily OS_FAMILY_WINNT = new OsFamily("nt", new OsFamily[] {OS_FAMILY_WINDOWS});
 
     /**
      * All Windows 9x based OSes.
      */
-    public static final OsFamily OS_FAMILY_WIN9X = new OsFamily("win9x",
-            new OsFamily[] { OS_FAMILY_WINDOWS, OS_FAMILY_DOS });
+    public static final OsFamily OS_FAMILY_WIN9X = new OsFamily("win9x", new OsFamily[] {OS_FAMILY_WINDOWS, OS_FAMILY_DOS});
 
     /**
      * OS/2.
      */
-    public static final OsFamily OS_FAMILY_OS2 = new OsFamily("os/2", new OsFamily[] { OS_FAMILY_DOS });
+    public static final OsFamily OS_FAMILY_OS2 = new OsFamily("os/2", new OsFamily[] {OS_FAMILY_DOS});
 
     /**
      * Netware.
@@ -78,7 +77,7 @@ public final class Os {
     /**
      * OSX.
      */
-    public static final OsFamily OS_FAMILY_OSX = new OsFamily("osx", new OsFamily[] { OS_FAMILY_UNIX, OS_FAMILY_MAC });
+    public static final OsFamily OS_FAMILY_OSX = new OsFamily("osx", new OsFamily[] {OS_FAMILY_UNIX, OS_FAMILY_MAC});
 
     private static final String OS_NAME = System.getProperty("os.name").toLowerCase(Locale.US);
     private static final String OS_ARCH = System.getProperty("os.arch").toLowerCase(Locale.US);
@@ -87,8 +86,8 @@ public final class Os {
     private static final OsFamily OS_FAMILY;
     private static final OsFamily[] OS_ALL_FAMILIES;
 
-    private static final OsFamily[] ALL_FAMILIES = { OS_FAMILY_DOS, OS_FAMILY_MAC, OS_FAMILY_NETWARE,
-            OS_FAMILY_OS2, OS_FAMILY_OSX, OS_FAMILY_UNIX, OS_FAMILY_WINDOWS, OS_FAMILY_WINNT, OS_FAMILY_WIN9X };
+    private static final OsFamily[] ALL_FAMILIES = {OS_FAMILY_DOS, OS_FAMILY_MAC, OS_FAMILY_NETWARE, OS_FAMILY_OS2, OS_FAMILY_OSX, OS_FAMILY_UNIX,
+        OS_FAMILY_WINDOWS, OS_FAMILY_WINNT, OS_FAMILY_WIN9X};
 
     static {
         OS_FAMILY = determineOsFamily();