What type of loan(s) can be closed for a JLG top-up loan?

[dylanrobson <dy...@disroot.org>]

Hello everyone,

I have been working on some recent changes to fix some problems regarding group top-up loans (FIN-609).
I then wrote integration tests - to verify that the previous loan is closed after the top-up loan is disbursed.

…

When a top-up loan application is created, the user selects which existing active loan account to close.

Which combination of the following loan account types should be options for the user to close when creating a new JLG top-up loan?
	1. Individual (client) loans can be closed for the JLG top-up.
	2. Group loans can be closed for the JLG top-up. 
	3. JLG loans can be closed for the JLG top-up.

Currently on demo.openmf, the server allows only individual and JLG loan account types to be closed for the JLG top-up. I wanted to verify that this is the intended behavior.

Thanks
— Dylan

Re: What type of loan(s) can be closed for a JLG top-up loan?

[dy...@disroot.org]

Hello everyone,
	Just wanted to politely bump this to see if anyone can provide feedback about my previous question in the below thread:

	Which combination of the following loan account types should be options for the user to close when creating a new JLG top-up loan?
Hi Santosh,
Thanks for the feedback.

	Let's confirm this by any Community member used [top-up] with group loan.I would like to confirm this as well - does anybody in the community have a use case for group top-up loan?

It was my impression that there was a use case for group top-up loans because https://issues.apache.org/jira/browse/FINERACT-609 (https://issues.apache.org/jira/browse/FINERACT-609)
was titled "Topup loan is not working for Group loans" and its description was about group top-up loans also. Additionally, I saw the comment at
https://issues.apache.org/jira/browse/FINERACT-609?focusedCommentId=16865338&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16865338 (https://issues.apache.org/jira/browse/FINERACT-609?focusedCommentId=16865338&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16865338)
which says you thought that the issue was reported by someone using both group and JLG loans for top-up. (Unfortunately it appears that the original reporter of this issue is unknown, so we can't confirm their use case).
I don't think JLG and group top-up loan implementation appear to be too different from each other.
Any further feedback would be greatly appreciated.

Thanks and regards
-- Dylan

July 7, 2019 11:23 PM, "Santosh Math" <santosh@confluxtechnologies.com (mailto:santosh@confluxtechnologies.com?to=%22Santosh%20Math%22%20<sa...@confluxtechnologies.com>)> wrote:
Hi Dylan,To my knowledge, top-up loan could be implemented only for Individual and JLG loans and not for Group loans. Let's confirm this by any Community member used it with group loan. 
On Sun, Jul 7, 2019 at 7:06 AM dylanrobson <dylanrobson@disroot.org (mailto:dylanrobson@disroot.org)> wrote: Hello everyone,

I have been working on some recent changes to fix some problems regarding group top-up loans (FIN-609).
I then wrote integration tests - to verify that the previous loan is closed after the top-up loan is disbursed.

…

When a top-up loan application is created, the user selects which existing active loan account to close.

Which combination of the following loan account types should be options for the user to close when creating a new JLG top-up loan?
1. Individual (client) loans can be closed for the JLG top-up.
2. Group loans can be closed for the JLG top-up.
3. JLG loans can be closed for the JLG top-up.

Currently on demo.openmf, the server allows only individual and JLG loan account types to be closed for the JLG top-up. I wanted to verify that this is the intended behavior.

Thanks
— Dylan
--Thanks & Regards

	Santosh Math

	QA Engineer

	Conflux Technologies Pvt Ltd (http://www.confluxtechnologies.com/)| Office: +91-080-41208662 | 

	Address: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block, Bengaluru, Karnataka, 560043 INDIA

Re: What type of loan(s) can be closed for a JLG top-up loan?

[Santosh Math <sa...@confluxtechnologies.com>]

Hi Dylan,
To my knowledge, top-up loan could be implemented only for Individual and
JLG loans and not for Group loans. Let's confirm this by any Community
member used it with group loan.

On Sun, Jul 7, 2019 at 7:06 AM dylanrobson <dy...@disroot.org> wrote:

> Hello everyone,
>
> I have been working on some recent changes to fix some problems regarding
> group top-up loans (FIN-609).
> I then wrote integration tests - to verify that the previous loan is
> closed after the top-up loan is disbursed.
>
> …
>
> When a top-up loan application is created, the user selects which existing
> active loan account to close.
>
> Which combination of the following loan account types should be options
> for the user to close when creating a new JLG top-up loan?
>         1. Individual (client) loans can be closed for the JLG top-up.
>         2. Group loans can be closed for the JLG top-up.
>         3. JLG loans can be closed for the JLG top-up.
>
> Currently on demo.openmf, the server allows only individual and JLG loan
> account types to be closed for the JLG top-up. I wanted to verify that this
> is the intended behavior.
>
> Thanks
> — Dylan
>
>

-- 
Thanks & Regards

Santosh Math

*QA Engineer*

*Conflux Technologies Pvt Ltd <http://www.confluxtechnologies.com/>*
| *Office*: +91-080-41208662 |

*Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
Bengaluru, Karnataka, 560043 INDIA