[GitHub] flink pull request #5214: [FLINK-8324] [kafka] Expose another offsets metric...

[tony810430 <gi...@git.apache.org>]

GitHub user tony810430 opened a pull request:

    https://github.com/apache/flink/pull/5214

    [FLINK-8324] [kafka] Expose another offsets metrics by using new metric API to specify user defined variables

    ## What is the purpose of the change
    
    Add two metrics for current offsets and committed offsets by using new metric API, which can define user scope variables.
    
    ## Brief change log
    
      - add two metrics for current offsets and committed offsets
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not documented


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tony810430/flink FLINK-8324

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5214
    
----
commit 76675d5e3fdcc023142724838eeddc1c2029e120
Author: Tony Wei <to...@...>
Date:   2017-12-28T02:19:24Z

    [FLINK-8324] Expose another offsets metrics by using new metric API to specify user defined variables

----


---

[GitHub] flink pull request #5214: [FLINK-8324] [kafka] Expose another offsets metric...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5214


---

[GitHub] flink issue #5214: [FLINK-8324] [kafka] Expose another offsets metrics by us...

[tzulitai <gi...@git.apache.org>]

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/5214
  
    Good idea. I think we should also update the metrics doc to educate this addition.


---

[GitHub] flink issue #5214: [FLINK-8324] [kafka] Expose another offsets metrics by us...

[tzulitai <gi...@git.apache.org>]

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/5214
  
    Thanks for the PR @tony810430. The changes LGTM, will merge this a bit later.


---

[GitHub] flink issue #5214: [FLINK-8324] [kafka] Expose another offsets metrics by us...

[tony810430 <gi...@git.apache.org>]

Github user tony810430 commented on the issue:

    https://github.com/apache/flink/pull/5214
  
    @tzulitai Have updated the metrics doc.


---