You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/12 22:27:37 UTC

[GitHub] [incubator-superset] bkyryliuk opened a new issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

bkyryliuk opened a new issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243


   New pie chart labels look messy in the dashboard view and there are some issues in the explore view as well. 
   Screenshots provide additional context
   
   ### Expected results
   
   ![image](https://user-images.githubusercontent.com/5727938/95795301-e28a1b80-0c9e-11eb-8442-0af8dd8f22dd.png)
   
   
   ### Actual results
   ![image](https://user-images.githubusercontent.com/5727938/95795245-ba9ab800-0c9e-11eb-8331-53778abf2391.png)
   
   ![image](https://user-images.githubusercontent.com/5727938/95795447-339a0f80-0c9f-11eb-90b7-69ecfdc3b5b2.png)
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243#issuecomment-707395580


   Another example, current:
   ![image](https://user-images.githubusercontent.com/5727938/95798873-ea9a8900-0ca7-11eb-9162-7bc0f9599a36.png)
   
   Previous:
   ![image](https://user-images.githubusercontent.com/5727938/95798966-21709f00-0ca8-11eb-84b8-2f7040275ebb.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243#issuecomment-707990338


   > @bkyryliuk this PR should fix threshold + blurriness problems introduced by the new chart: [apache-superset/superset-ui#806](https://github.com/apache-superset/superset-ui/pull/806)
   
   Wow, thank you for the prompt fix!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] junlincc closed issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

Posted by GitBox <gi...@apache.org>.
junlincc closed issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk edited a comment on issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

Posted by GitBox <gi...@apache.org>.
bkyryliuk edited a comment on issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243#issuecomment-707376639


   cc @junlincc @eugeniamz @villebro 
   probably introduced here: https://github.com/apache/incubator-superset/pull/10966


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243#issuecomment-707694117


   @bkyryliuk this PR should fix threshold + blurriness problems introduced by the new chart: https://github.com/apache-superset/superset-ui/pull/806


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] junlincc commented on issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243#issuecomment-707464059


   @bkyryliuk hey Bogdan, thanks for reporting. we are aware of this issue and will work on it! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] junlincc commented on issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243#issuecomment-712563927


   issue resolved! thank you so much Ville!! closing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243#issuecomment-707376355


   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.98. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243#issuecomment-707376639


   cc @junlincc @eugeniamz 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk edited a comment on issue #11243: [Bug] New pie chart labels and control overlap with controls & actual viz

Posted by GitBox <gi...@apache.org>.
bkyryliuk edited a comment on issue #11243:
URL: https://github.com/apache/incubator-superset/issues/11243#issuecomment-707376639


   cc @junlincc @eugeniamz @villebro 
   probably introduced here: https://github.com/apache/incubator-superset/pull/10966
   
   Disabling put labels outside makes things even worse, a potential fix could be a certain threshold for the values to show, e.g. only values > 5 % 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org